fix: update file size calculation in dataset info#689
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dataset metadata contract so the UI displays a dataset “size” value sourced from backend metadata computed from the underlying Arrow table rather than a Pandas DataFrame memory-usage estimate.
Changes:
- Backend: replaces
general_info.memory_usage_mbwithgeneral_info.file_size_mbcomputed fromarrow_table.nbytes. - Frontend: switches the dataset visualization header to read
general_info.file_size_mbfor display.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DashAI/front/src/components/DatasetVisualization.jsx | Switches the header’s displayed size field from memory_usage_mb to file_size_mb. |
| DashAI/back/dataloaders/classes/dashai_dataset.py | Changes the computed dataset size metadata to use Arrow table byte size and emits it as file_size_mb. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Collaborator
Author
|
It previously used the size of the pandas DataFrame. Now, it retrieves the size from the Arrow file generated in .dashai |
Irozuku
requested changes
Jun 9, 2026
cristian-tamblay
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how dataset file size is calculated and displayed in the dataset visualization component. Instead of reporting the in-memory size, the system now reports the actual file size based on the Arrow table, ensuring more accurate information is shown to users.
Backend: File size calculation update
file_size_mbusing the Arrow table's byte size instead of the DataFrame's memory usage, providing a more accurate file size metric. (DashAI/back/dataloaders/classes/dashai_dataset.py)Frontend: File size display update
file_size_mbfield for displaying file size in the dataset visualization header, instead of the previousmemory_usage_mbfield. (DashAI/front/src/components/DatasetVisualization.jsx)