Repository navigation
feat(branding): replace the remaining hardcoded Documenso strings (batch 2) #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ export const EmailDomainsUpsell = () => { | |
| )} | ||
|
|
||
| <span className="truncate"> | ||
| {isBranded ? <Trans>Sending from your domain</Trans> : <Trans>Sending from app.documenso.com</Trans>} | ||
| {isBranded ? <Trans>Sending from your domain</Trans> : <Trans>Sending from Crove Sign</Trans>} | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| </span> | ||
| </motion.div> | ||
| </AnimatePresence> | ||
|
|
@@ -147,7 +147,7 @@ export const EmailDomainsUpsell = () => { | |
| transition={{ duration: 0.28, ease: EASE }} | ||
| className="flex min-w-0 items-center gap-1.5" | ||
| > | ||
| <span className="min-w-0 truncate">{isBranded ? brandedSender.name : 'Documenso'}</span> | ||
| <span className="min-w-0 truncate">{isBranded ? brandedSender.name : 'Crove Sign'}</span> | ||
|
|
||
| {/* Inside the keyed row so it exits with the name and pops back in on every cycle step. */} | ||
| {isBranded && ( | ||
|
|
@@ -174,7 +174,7 @@ export const EmailDomainsUpsell = () => { | |
| transition={{ duration: 0.28, ease: EASE }} | ||
| className="truncate" | ||
| > | ||
| {isBranded ? brandedSender.email : 'noreply@app.documenso.com'} | ||
| {isBranded ? brandedSender.email : 'noreply@sign.crove.com'} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| </motion.p> | ||
| </AnimatePresence> | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -57,8 +57,8 @@ export const sendForgotPassword = async ({ userId }: SendForgotPasswordOptions) | |||||||||
| name: user.name || '', | ||||||||||
| }, | ||||||||||
| from: { | ||||||||||
| name: env('NEXT_PRIVATE_SMTP_FROM_NAME') || 'Documenso', | ||||||||||
| address: env('NEXT_PRIVATE_SMTP_FROM_ADDRESS') || 'noreply@documenso.com', | ||||||||||
| name: env('NEXT_PRIVATE_SMTP_FROM_NAME') || 'Crove Sign', | ||||||||||
| address: env('NEXT_PRIVATE_SMTP_FROM_ADDRESS') || 'noreply@sign.crove.com', | ||||||||||
|
Comment on lines
+60
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of duplicating the environment variable checks and fallback values here, please import and use the centralized
Suggested change
|
||||||||||
| }, | ||||||||||
| subject: i18n._(msg`Forgot Password?`), | ||||||||||
| html, | ||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,8 +50,8 @@ export const sendResetPassword = async ({ userId, source }: SendResetPasswordOpt | |||||
| name: user.name || '', | ||||||
| }, | ||||||
| from: { | ||||||
| name: env('NEXT_PRIVATE_SMTP_FROM_NAME') || 'Documenso', | ||||||
| address: env('NEXT_PRIVATE_SMTP_FROM_ADDRESS') || 'noreply@documenso.com', | ||||||
| name: env('NEXT_PRIVATE_SMTP_FROM_NAME') || 'Crove Sign', | ||||||
| address: env('NEXT_PRIVATE_SMTP_FROM_ADDRESS') || 'noreply@sign.crove.com', | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fallback name on line 53 was missed and still defaults to
Suggested change
coderabbitai[bot] marked this conversation as resolved.
|
||||||
| }, | ||||||
| subject, | ||||||
| html, | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the brand name has been changed from
'Documenso'to'Crove Sign', the preview letter (on lines 12, 21, and 30) should be updated from'D'to'C'to match the new brand name.