Repository navigation
release.yml: verify the C128 build outputs too - #10
Merged
Merged
Conversation
The release job's verify step predates the C128 port and only checked the C64 PRGs, although the same make_petproject.sh run puts the C128 set and its boot sector on the released disk. Add the C128 checks build.yml already runs so a C128-only breakage fails the release instead of shipping. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release job's verify step predates the C128 port and only checked the C64 PRGs, although the same
make_petproject.shrun puts the C128 editor, modules and boot sector on the released disk. This copies the C128 checks from build.yml into release.yml, so a C128-only breakage fails the release instead of shipping a bad disk.No change to what is built or published.
Verification
The checks are the ones build.yml already runs on every push and pull request (they passed on the PR 9 merge). The
head -c 3 ... | grep -q CBMboot-sector check was also run against a local build.🤖 Generated with Claude Code