Skip to content

Improvement: Add missing const to elements_are_family arguments #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandro-elsweijer merged 1 commit into from
Aug 26, 2026
Merged

Improvement: Add missing const to elements_are_family arguments #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ t8_default_scheme_hex::element_get_ancestor_id (const t8_element_t *elem, const
}

int
t8_default_scheme_hex::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_hex::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
{
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ struct t8_default_scheme_hex: public t8_default_scheme_common<T8_ECLASS_HEX, t8_
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is,
* the element with highest level that still has both given elements as
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_line/t8_default_line.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ t8_default_scheme_line::element_get_ancestor_id (const t8_element_t *elem, int l
}

int
t8_default_scheme_line::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_line::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
int i;
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_line/t8_default_line.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ struct t8_default_scheme_line: public t8_default_scheme_common<T8_ECLASS_LINE, t
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is,
* the element with highest level that still has both given elements as
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_prism/t8_default_prism.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ t8_default_scheme_prism::element_extrude_face (const t8_element_t *face, t8_elem
}

int
t8_default_scheme_prism::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_prism::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
for (int i = 0; i < T8_DPRISM_CHILDREN; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_prism/t8_default_prism.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ struct t8_default_scheme_prism: public t8_default_scheme_common<T8_ECLASS_PRISM,
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is, the element with highest level that still has
* both given elements as descendants.
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_pyramid/t8_default_pyramid.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ t8_default_scheme_pyramid::element_set_linear_id (t8_element_t *elem, int level,
}

int
t8_default_scheme_pyramid::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_pyramid::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
const int num_siblings = element_get_num_siblings (fam[0]);
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_pyramid/t8_default_pyramid.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ struct t8_default_scheme_pyramid: public t8_default_scheme_common<T8_ECLASS_PYRA
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is, the element with highest level that still has both
* given elements as descendants.
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_quad/t8_default_quad.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ t8_default_scheme_quad::element_get_ancestor_id (const t8_element_t *elem, int l
}

int
t8_default_scheme_quad::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_quad::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
for (int i = 0; i < P4EST_CHILDREN; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_quad/t8_default_quad.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ struct t8_default_scheme_quad: public t8_default_scheme_common<T8_ECLASS_QUAD, t
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is,
* the element with highest level that still has both given elements as
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_tet/t8_default_tet.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ t8_default_scheme_tet::element_get_ancestor_id (const t8_element_t *elem, int le
}

int
t8_default_scheme_tet::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_tet::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
for (int i = 0; i < T8_DTET_CHILDREN; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_tet/t8_default_tet.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ struct t8_default_scheme_tet: public t8_default_scheme_common<T8_ECLASS_TET, t8_
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is, the element with highest level that still has both
* given elements as descendants.
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_tri/t8_default_tri.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ t8_default_scheme_tri::element_get_ancestor_id (const t8_element_t *elem, int le
}

int
t8_default_scheme_tri::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_tri::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
{
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_tri/t8_default_tri.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ struct t8_default_scheme_tri: public t8_default_scheme_common<T8_ECLASS_TRIANGLE
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is, the element with highest level that still has both
* given elements as descendants.
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ t8_default_scheme_vertex::element_get_ancestor_id ([[maybe_unused]] const t8_ele
}

int
t8_default_scheme_vertex::elements_are_family (t8_element_t *const *fam) const
t8_default_scheme_vertex::elements_are_family (const t8_element_t *const *fam) const
{
#if T8_ENABLE_DEBUG
for (int i = 0; i < T8_DVERTEX_CHILDREN; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ struct t8_default_scheme_vertex: public t8_default_scheme_common<T8_ECLASS_VERTE
* \note level 0 elements do not form a family.
*/
int
elements_are_family (t8_element_t *const *fam) const;
elements_are_family (const t8_element_t *const *fam) const;

/** Compute the nearest common ancestor of two elements. That is,
* the element with highest level that still has both given elements as
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_scheme.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ struct t8_scheme
* \note level 0 elements do not form a family.
*/
inline bool
elements_are_family (const t8_eclass_t tree_class, t8_element_t *const *fam) const
elements_are_family (const t8_eclass_t tree_class, const t8_element_t *const *fam) const
{
return std::visit ([&] (auto &&scheme) { return scheme.elements_are_family (fam); }, eclass_schemes[tree_class]);
};
Expand Down
2 changes: 1 addition & 1 deletion src/t8_schemes/t8_standalone/t8_standalone_implementation.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ struct t8_standalone_scheme: public t8_scheme_helpers<TEclass, t8_standalone_sch
* \note level 0 elements do not form a family.
*/
static constexpr int
elements_are_family (t8_element_t *const *fam) noexcept
elements_are_family (const t8_element_t *const *fam) noexcept
{
#if T8_ENABLE_DEBUG
const int num_siblings = element_get_num_siblings (fam[0]);
Expand Down
Loading