Repository navigation
docs: add Google-style docs to diracx-logic and remove D100-D300 from per-file-ignores for it (#1076) - #1167
Merged
aldbr merged 5 commits intoNov 5, 2026
Conversation
martynia
force-pushed
the
janusz_rest2_googledocs_diracx-logic_1004
branch
from
November 4, 2026 15:54
7a54e90 to
bac0e3d
Compare
4 tasks
martynia
force-pushed
the
janusz_rest2_googledocs_diracx-logic_1004
branch
from
November 5, 2026 10:24
577b2d4 to
a48ebb8
Compare
martynia
marked this pull request as ready for review
November 5, 2026 13:40
Logic docstrings now describe behaviour and domain exceptions; the HTTP contract (status codes, headers, admin policy) stays in diracx-routers. - Fix statements that did not match the code: heartbeat data goes to HeartBeatLoggingInfo, calculate_priority mutates all_tqs_data, a scope needs exactly one VO, and the unreachable NotImplementedError is gone. - Complete Raises sections for the token, flow and submission functions. - Remove paragraphs copied from router docstrings and mentions of router behaviour (admin bypass, token enrichment, ETag/Vary). - Restore the transformations package docstring (D104 is ignored). Assisted-by: Claude:claude-opus-5-5
An empty ignore list behaves the same as having no entry, and no other glob in the table matches these source trees, so D100-D103 keep applying to diracx-db, diracx-cli, diracx-core and diracx-logic. Assisted-by: Claude:claude-opus-5-5
aldbr
approved these changes
Nov 5, 2026
aldbr
enabled auto-merge (squash)
November 5, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add google style comments to dirac-logic (#1076)