Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ublication condition
…emver ranges and update deletion logic to clean up associated tags
…auto-updater with support for environment-based overrides
…o-show handling across environments
…nvironment-aware user data paths
…support beta channel distribution
…flow configuration
…e in core-node, and bump versions to 1.0.0-beta.8/2.0.0-beta.8
…op server-process path resolution
… versions to 1.0.0-beta.11
…oad support for unsupported OS
…mentation to plugin loading
…ersion to 1.0.0-beta.34
…ert storage methods to arrow functions
…d simulation files
… readiness before UI launch
…e prompts and disabling shell execution
…scovery validation
…ry UI components.
- Fix login credential injection: inject on editor.construct.net origin using localforage instead of raw IndexedDB on account.construct.net - Respect existing PLAYWRIGHT_BROWSERS_PATH env var - Skip browser download if chrome binary already exists - Register all dialog listeners immediately after navigation/login - Add recursive re-registration to notNowBtn listener - Add E2E test for login with env vars (C3_USERNAME/C3_PASSWORD)
…ping redundant API logins if auth state exists
…packages and plugins
Deploying pipelab with
|
| Latest commit: |
2af2631
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6df913e.pipelab.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // We only want to intercept things that we actually have MSW handlers for. | ||
| const shouldIntercept = | ||
| originalHost && | ||
| (originalHost.includes("poki.io") || |
| regex(/[A-Z]/, "Password must contain at least one uppercase letter"), | ||
| regex(/[0-9]/, "Password must contain at least one number"), | ||
| regex( | ||
| /[!@#$%^&*()_+-=[\]{};':"|\<>?,./`~.]/, |
| { label: "Lowercase letter", isValid: /[a-z]/.test(pwd) }, | ||
| { label: "Uppercase letter", isValid: /[A-Z]/.test(pwd) }, | ||
| { label: "Numeric digit", isValid: /[0-9]/.test(pwd) }, | ||
| { label: "Special symbol", isValid: /[!@#$%^&*()_+-=[\]{};':"|\<>?,./`~.]/.test(pwd) }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Construct 3 export pipeline's "stuck on login" bug and improves dialog listener reliability.
Changes
Login credential injection fix
Browser download optimization
Dialog listener improvements
E2E test
Testing
All 3 E2E tests pass:
Files changed
plugins/plugin-construct/src/assets/script.ts— login injection + listener registrationplugins/plugin-construct/src/assets/listeners.ts— notNowBtn recursive re-registrationplugins/plugin-construct/src/export-shared.ts— browser path + download skipplugins/plugin-construct/tests/e2e/construct.spec.ts— login E2E test