feat: token exchange endpoint and documentation - #258
Open
taleodor wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pavel Shukhman <pavel@reliza.io>
oej
requested changes
Aug 26, 2026
oej
left a comment
oej
left a comment
Collaborator
There was a problem hiding this comment.
Good work, just some smaller questions
| ## The token endpoint | ||
|
|
||
| The token endpoint is `POST /token`, relative to the TEA API base URL, and is defined in | ||
| [the OpenAPI specification](../spec/openapi.yaml). It is an OAuth 2.0 token endpoint as defined |
Collaborator
There was a problem hiding this comment.
Will this link survive the official doc process (ECMA docs) ?
| Token lifetime, storage, rotation, and revocation are implementation matters and are deliberately | ||
| not specified. Two rules keep clients simple in spite of that: | ||
|
|
||
| * Servers __should__ return `expires_in`, so that a client can obtain a new token before the current |
Collaborator
There was a problem hiding this comment.
Is this a header, part of the JWT or?
Collaborator
|
If a client connects to a server that has no "/token" endpoint and no auth - will it receive a 404 which feels weird. i would like that every TEA service has /token endpoint and if no auth is in play, simply return "200 ok" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements /token endpoint and corresponding documentation. The endpoint is not required for an open (no-auth TEA server), but if auth is present, the /token endpoint is required. If /token endpoint is used, at least HTTP Basic authentication must be supported, while there are other options.