Repository navigation
Conversation
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS 1.3 negotiates cipher suites, key-exchange groups, and signature schemes separately (RFC 8446 section 4.1.1 (https://www.rfc-editor.org/rfc/rfc8446.html#section-4.1.1)). The current schema places groups and signature schemes only inside cipher-suite entries, requiring duplication to represent an endpoint inventory.
This PR adds optional protocolProperties.tlsGroups and protocolProperties.tlsSignatureSchemes. These inventories do not imply negotiation preference, selected values, or compatibility between every listed combination.
Existing suite-level fields retain their validation constraints through shared definitions. Existing documents remain valid; documents using the new properties require the updated schema.
Addresses the TLS portion of #1162 without closing the issue.
Following our discussion in the meeting, I came up with these changes. I’d be happy to hear your thoughts, @bhess!