perf: get_component_by_purl to use early exit generator - #1037
Open
saquibsaifee wants to merge 1 commit into
Open
perf: get_component_by_purl to use early exit generator#1037saquibsaifee wants to merge 1 commit into
saquibsaifee wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
Signed-off-by: saquibsaifee <saquibsaifee2@gmail.com>
saquibsaifee
force-pushed
the
jules-15072243337751192311-9f856d4e
branch
from
September 1, 2026 21:36
f1349d6 to
1684d29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
💡 What: Replaced the full list comprehension traversal in
cyclonedx.model.bom.Bom.get_component_by_purlwith a generator-based early exit logic that avoids full list traversal when uniqueness is guaranteed or only the first element is required. It still strictly adheres to the existing logic oflen(found) == 1meaning it returnsNoneif duplicates exist, by checking if a second element exists vianext(gen, None).🎯 Why: The previous logic (
[x for x in self.components if x.purl == purl]) traversed the entire list of components (SortedSet). For large BOMs containing thousands or even hundreds of thousands of components, lookups for components by PURL resulted in heavy CPU load.📊 Measured Improvement:
In a benchmark mapping a BOM with 100,001 components:
AI Tool Disclosure
JulesGemini 3.1 ProAffirmation