Skip to content

Fix: post exec action fixes - #55

Merged
Zacgoose merged 2 commits into
mainfrom
dev
Oct 16, 2026
Merged

Zacgoose merged 2 commits into
mainfrom
dev

Conversation

@Zacgoose

Copy link
Copy Markdown
Contributor

This pull request improves how post-execution scripts are run for sequential jobs, ensuring they execute on the correct (pinned) worker and preventing potential deadlocks when the worker pool is full. It also enhances logging for PowerShell worker warmup scripts and adds a targeted test to verify the new behavior.

Orchestration and Worker Management:

  • Ensures that post-execution scripts for sequential runs are executed on the same pinned worker instead of requesting a new one, preventing deadlocks in worker pool exhaustion scenarios (OrchestratorService.cs). [1] [2] [3] [4]
  • Updates the RunPostExecutionAsync and RunScriptAsync methods to accept and use an optional PowerShellWorker parameter, so the correct worker is used for post-execution. [1] [2] [3]

PowerShell Worker Logging:

  • Improves warmup diagnostics by streaming warning, information, and error log records in real-time as the warmup script runs, preserving message order and timestamps (PowerShellWorker.cs).

Testing:

  • Adds a new test to verify that post-execution for sequential jobs runs on the pinned worker, and tracks which worker was used for post-execution (HungWorkerRecycleTests.cs, OrchestrationHarness.cs). [1] [2] [3]

Log warning, information, and error records as they arrive to preserve their timing and order. Detach handlers and clear commands and streams in a finally block.
@Zacgoose
Zacgoose requested a review from JohnDuprey October 16, 2026 19:16
@Zacgoose
Zacgoose merged commit f7fcbaf into main Oct 16, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants