feat(fleet): FleetService Connect API (nodes, certs, catalog) + Go/TS codegen#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds
cryptos.fleet.v1.FleetService, the Connect (gRPC-web) API the Fleet Manager web UI calls (the manager fans out to nodes over gRPC/mTLS behind it). Read-only RPCs this phase:ListNodes,GetNode,ListCertificates,ListProfiles,ListAdapters,ListAudit,ListEnrollments. Wires buf to generate the Connect Go server + a TypeScript client (Connect-ES v2).Also fixes a pre-commit false positive: the AI-tell text scan flagged
protoc-gen-connect-go's stock "Generated with a version of connect ..." boilerplate in generated files. Generated files carrying the standardCode generated ... DO NOT EDIT./@generated by protoc-gen-marker are now exempt from that text scan (emoji scan unchanged). Worth propagating to the project-template.Closes #41.
Notes
First of three PRs; merge order: api -> manager -> web (both consume these generated stubs). Follow-up: publish the generated Go module + TS package so downstream repos consume it as a real dependency instead of a local
replace/ vendored copy.How verified
buf lint+buf generateclean;task ci+task licensegreen. End-to-end: the manager serves these RPCs live against two real local CryptOS nodes and the web UI renders them (proven in the manager/web PRs).