Skip to content

Respect the project's model setting in prologue interpret - #289

Merged
woksin merged 2 commits into
mainfrom
fix/241-prologue-local-llm-setting
Oct 8, 2026
Merged

woksin merged 2 commits into
mainfrom
fix/241-prologue-local-llm-setting

Conversation

@woksin

@woksin woksin commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Fixed

@woksin woksin added the patch label Oct 8, 2026
@woksin woksin self-assigned this Oct 8, 2026
@woksin

woksin commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewer notes (not part of the release note).

  • Precedence: --no-llm overrides everything; an explicit local llm.enabled: false blocks the machine-wide fallback; an absent local setting keeps the fallback; an explicitly enabled local configuration resolves as before. The notice goes to stderr before the session starts, and the destination it names is the one the client uses (including ANTHROPIC_BASE_URL). An endpoint that is not an absolute URL is rejected before any client is created. The old LlmOptionsResolver.Resolve overload, which could not tell an absent setting from false, is removed (no production callers).
  • Review: cross-provider deep review (Opus 5.5 + GPT-6 Astra) passed with no blocking findings; its three advisories (Anthropic base-URL disclosure, scheme-less endpoints, the ambiguous overload) are fixed in a770804.
  • Local verification: restore, Release build with zero warnings, full dotnet test --configuration Release including integration, changed-file format and markdownlint — all exit 0 on 445658a; after the advisory fixes: Release build, CLI specs (3130 passed, 6 Windows-only skips), templating and conformance specs, format and markdownlint. Other-OS lanes run in CI only.

@woksin
woksin merged commit 84c737c into main Oct 8, 2026
11 of 14 checks passed
@woksin
woksin deleted the fix/241-prologue-local-llm-setting branch October 8, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant