Repository navigation
Refactored react_modal.js.jsx into modular functional TypeScript comp… - #1822
Open
danielrafailov wants to merge 2 commits into
Open
danielrafailov wants to merge 2 commits into
danielrafailov wants to merge 2 commits into
Conversation
danielrafailov
force-pushed
the
refactor-react-modal
branch
from
October 24, 2026 18:37
65acfc9 to
ad04b64
Compare
Coverage Report for CI Build 40124537948Coverage increased (+0.3%) to 60.638%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
react_modal.js.jsxby converting legacy class-based components into modular functional components. I also converted the files from JavaScript to TypeScript as requested to catch bugs at compile time and encourage documentation.CampusMap,CourseModal,DayBox,Description,FocusModal,MapModal, andMapSidebarinto their own functional components, and created type interfaces for all of their props and state variables.ModalContent: Removed because it was simply a wrapper forDescription, whichCourseModalwas already rendering.VideoclassfocusInfostate variableformatCourseNamehelper functionType of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments
CampusMap.tsx, I noticed a bug where the Leaflet map does not render when opening the Campus Map modal from the timetable view. I asked gemini about this and it said that this is a known CSS issue where the Leaflet map container defaults to a height of0px(or does not render properly until resized).types.tsto document what each type represents and where it is used across the components. Let me know what you think of this.