Repository navigation
Converted SideBar.js, FocusBar.js, and NavBar.js.jsx to tsx files - #1815
Merged
david-yz-liu merged 7 commits intoOct 14, 2026
Merged
david-yz-liu merged 7 commits into
david-yz-liu merged 7 commits into
Conversation
Coverage Report for CI Build 38581845116Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 60.407%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions41 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
| } | ||
|
|
||
| const filteredSearch = query => { | ||
| const filteredSearch = (query: string) => { |
Contributor
There was a problem hiding this comment.
Overall it's great to add parameter type annotations. Let's go further and add return type annotations as well (for all functions in this file).
david-yz-liu
approved these changes
Oct 14, 2026
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @danielrafailov!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Converted SideBar.js, FocusBar.jsm and NavBar.js.jsx to tsx files
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: