Skip to content

Converted SideBar.js, FocusBar.js, and NavBar.js.jsx to tsx files - #1815

Merged
david-yz-liu merged 7 commits into
Courseography:masterfrom
danielrafailov:convert-components-to-typescript
Oct 14, 2026
Merged

david-yz-liu merged 7 commits into
Courseography:masterfrom
danielrafailov:convert-components-to-typescript

Conversation

@danielrafailov

@danielrafailov danielrafailov commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Converted SideBar.js, FocusBar.jsm and NavBar.js.jsx to tsx files

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls

coveralls commented Oct 12, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 38581845116

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 60.407%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 17 of 17 lines across 4 files are fully covered (100%).
  • 41 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

41 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
app/Models/Meeting.hs 20 74.77%
app/WebParsing/UtsgJsonParser.hs 20 28.57%
app/Database/Tables.hs 1 85.71%

Coverage Stats

Coverage Status
Relevant Lines: 4303
Covered Lines: 2658
Line Coverage: 61.77%
Relevant Branches: 1001
Covered Branches: 546
Branch Coverage: 54.55%
Branches in Coverage %: Yes
Coverage Strength: 157.04 hits per line

💛 - Coveralls

Comment thread js/components/graph/Sidebar.tsx Outdated
}

const filteredSearch = query => {
const filteredSearch = (query: string) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's great to add parameter type annotations. Let's go further and add return type annotations as well (for all functions in this file).

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielrafailov!

@david-yz-liu
david-yz-liu merged commit e034c52 into Courseography:master Oct 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants