Skip to content

Remove period after instructor's first name in course info modal#1743

Merged
david-yz-liu merged 3 commits into
Courseography:masterfrom
r-weng:remove-instructor-name-period
Jun 29, 2026
Merged

Remove period after instructor's first name in course info modal#1743
david-yz-liu merged 3 commits into
Courseography:masterfrom
r-weng:remove-instructor-name-period

Conversation

@r-weng

@r-weng r-weng commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

This pull request removes the period after an instructor's first name in the course info modal, which is likely a holdover from when only the instructor's first initial was displayed.

...

Screenshots of your changes (if applicable) Screenshot 2026-06-27 at 12 49 23 PM (before) Screenshot 2026-06-27 at 12 49 48 PM (after)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 13

Coverage remained the same at 58.998%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3965
Covered Lines: 2405
Line Coverage: 60.66%
Relevant Branches: 964
Covered Branches: 503
Branch Coverage: 52.18%
Branches in Coverage %: Yes
Coverage Strength: 164.02 hits per line

💛 - Coveralls

@r-weng r-weng requested a review from david-yz-liu June 27, 2026 17:13

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @r-weng!

@david-yz-liu david-yz-liu merged commit 107873a into Courseography:master Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants