Fix scrollbar bug#1742
Open
AngelsandDevsLOL wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 0Coverage remained the same at 58.998%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR removes the scrollbar on the /graph and /generate webpages, which appeared because the page content overflowed by 50px (from the navbar height) past the viewport.
This PR decreases the height of the div with id of
react-graph, which holds the svg graph, to account for the 50px navbar. This change affects the /graph and /draw webpage. It fixes the scrollbar on the /graph webpage, but does not fix the remaining 50px overflow on the /draw webpage (because the about-div takes up another 50px). However, because the svg graph in /generate is held on the same level as another div, the height of the parent div was changed instead. Thus, at 100% zoom, the webpages should fit on the screen with no overflow.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)