Skip to content

Fix scrollbar bug#1742

Open
AngelsandDevsLOL wants to merge 2 commits into
Courseography:masterfrom
AngelsandDevsLOL:fix-scrollbar-bug
Open

Fix scrollbar bug#1742
AngelsandDevsLOL wants to merge 2 commits into
Courseography:masterfrom
AngelsandDevsLOL:fix-scrollbar-bug

Conversation

@AngelsandDevsLOL

@AngelsandDevsLOL AngelsandDevsLOL commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

This PR removes the scrollbar on the /graph and /generate webpages, which appeared because the page content overflowed by 50px (from the navbar height) past the viewport.

This PR decreases the height of the div with id of react-graph, which holds the svg graph, to account for the 50px navbar. This change affects the /graph and /draw webpage. It fixes the scrollbar on the /graph webpage, but does not fix the remaining 50px overflow on the /draw webpage (because the about-div takes up another 50px). However, because the svg graph in /generate is held on the same level as another div, the height of the parent div was changed instead. Thus, at 100% zoom, the webpages should fit on the screen with no overflow.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 0

Coverage remained the same at 58.998%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3965
Covered Lines: 2405
Line Coverage: 60.66%
Relevant Branches: 964
Covered Branches: 503
Branch Coverage: 52.18%
Branches in Coverage %: Yes
Coverage Strength: 164.13 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants