feat : add "Default tab" property on tab widget - #3923
Open
gabriel-desmarchelier wants to merge 1 commit into
Open
gabriel-desmarchelier wants to merge 1 commit into
gabriel-desmarchelier wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In my opinion, the Tab widget
Active Tabproperty behaviour is quite annoying :In the end, the saved
Active Tabis often the one in which the latest edit was made, rather than the one we actually want to be the default.I suggest a dedicated
Default Tabproperty :Active Tabproperty remains, though it's now mostly to be used at runtime (e.g. in rules) or for backward compatibilityDefault Tabdefault value is set to-1: in this case, we keep using theActive Tabproperty to set the default tabI come up with this proposal as a fix for a behavior we dislike, but there may be other ideas to think about :
Active Tabproperty but delete the behaviour of it changing in edition modeNote that the same could be implemented for NavigationTabs, if my proposal gets any support.
Here is bob file to test this feature :
active_and_default_tab.tar.gz
Checklist
Testing:
Documentation: