security(api): reject non-text controls in multiline SQL requests - #854
security(api): reject non-text controls in multiline SQL requests#854seonghobae wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent exact-head review requested for @opencode-agent @cwl-noema-review Please review the request-model security boundary, the C0/C1 allow/deny classification, tests, and documentation. Do not mutate the branch or merge. The current CI, Security Scan, and SAST Semgrep runs are queued and are not being treated as passing; CodeRabbit's automatic comment is rate-limited and is not a review. |
|
Superseded by canonical PR #832. The unique C1-range coverage from this duplicate has been ported test-first to #832 exact head |
Outcome
Reject non-text C0/C1 control characters in multiline
ApplySqlIn.sqlrequests before the API handler or DDL validator runs. Horizontal tab, LF, and CR remain valid multiline text whitespace.Closes #764.
Security boundary
\\t,\\n, and\\r.U+007F..U+009F).Evidence
22 passedintests/test_api_apply_sql.py.388 passed, 1 skipped(proxy variables removed because the sandbox injects a SOCKS proxy while the hash-locked CI environment does not).1 passed.app/schemas.py150/150 statements and 4/4 branches (100%).git diff --check: clean.Documentation
CHANGELOG.mdanddocs/api-security-checklist.mdrecord the implemented request boundary and point to its code/tests.Local tooling limitation
Repository guidance requests CodeGraph initialization/sync, but the executable is unavailable in this environment; direct
rgsymbol and caller search was used instead.