🎨 Palette: 테이블 삭제 버튼에 확인(Confirm) 다이얼로그 추가

[seonghobae]

Outcome

Table deletion from the edit modal now requires an explicit native confirmation that names the table. Confirming invokes the existing deletion path exactly once; canceling preserves the table and does not call the deletion callback.

Changes

• add the bounded confirmation guard to EditTableModal;
• add focused confirm/cancel regressions and cover the confirmed path in the modal coverage suite;
• record the user-visible safeguard in CHANGELOG.md and the canonical UI product contract;
• remove the accidentally generated 1,656-line frontend/pnpm-lock.yaml; the repository's canonical npm lockfile and dependencies are unchanged;
• close inherited owned-coverage gaps with test-only Prisma download, modal cancel/validation, malformed relation-handle, and singular back-relation cases.

No API, database, dependency, package-manager, workflow, or runtime-service contract changes.

Local verification

Published-tree evidence:

• focused tests: 4 files, 39 tests passed;
• complete frontend suite: 27 files, 200 tests passed;
• owned production coverage: 100% statements (1502/1502), branches (1137/1137), functions (323/323), and lines (1357/1357);
• TypeScript typecheck passed;
• production build passed;
• git diff --check passed.

Exact-head CI, Security Scan, Semgrep, zero unresolved valid findings, and qualifying independent current-head approval remain mandatory before merge. Queued, predecessor, rate-limited, or status-only evidence is not passing.

Summary by CodeRabbit

• 새로운 기능
  • 테이블 삭제 전 확인 대화상자가 표시됩니다.
  • 삭제를 취소하면 테이블이 그대로 유지되며, 확인한 경우에만 삭제됩니다.
  • Prisma 형식 내보내기 지원과 관계 처리 검증이 강화되었습니다.
• 개선 사항
  • 내보내기 기능의 다운로드 동작이 확장되었습니다.
  • 그룹 생성 시 이름이 비어 있으면 생성되지 않도록 동작을 보완했습니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f5f6c59d-9ef3-41ab-a0ae-efbd808d1b6f

📥 Commits

Reviewing files that changed from the base of the PR and between d629264 and 9ab456d.

📒 Files selected for processing (4)

• CHANGELOG.md
• frontend/src/App.coverage.test.tsx
• frontend/src/App.tsx
• frontend/src/erd/__tests__/prisma.test.ts

📝 Walkthrough

Walkthrough

테이블 삭제 전에 테이블 이름을 포함한 window.confirm을 표시합니다. 확인할 때만 삭제 콜백을 호출합니다. 관련 테스트와 Prisma 내보내기 및 관계 생성 테스트를 갱신했습니다.

Changes

테이블 삭제 확인

Layer / File(s)	Summary
삭제 확인 흐름 docs/ui-ux/product-spec.md, frontend/src/components/modals/EditTableModal.tsx, frontend/src/components/modals/*, CHANGELOG.md	제품 명세와 EditTableModal에 테이블 삭제 확인 절차를 추가했습니다. 확인 시 삭제하고 취소 시 모델을 유지하는 동작을 테스트합니다. 빈 그룹 이름 제출 검증도 추가했습니다.

내보내기 및 Prisma 검증

Layer / File(s)	Summary
Prisma 내보내기 커버리지 frontend/src/App.coverage.test.tsx	내보내기 모달 테스트에 export-prisma 버튼과 다운로드 호출 검증을 추가했습니다.
Prisma 관계 생성 검증 frontend/src/erd/__tests__/prisma.test.ts	legacy-id source handle을 사용하는 edge를 무시하고, primary-key 관계에 optional 단일 역방향 필드를 생성하는 동작을 검증했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant 사용자
  participant EditTableModal
  participant windowConfirm
  participant onDeleteTable
  사용자->>EditTableModal: 삭제 버튼 클릭
  EditTableModal->>windowConfirm: 테이블 이름을 포함한 확인 요청
  windowConfirm-->>EditTableModal: 확인 또는 취소 반환
  EditTableModal->>onDeleteTable: 확인 시 삭제 콜백 호출

Loading

Possibly related PRs

• ContextualWisdomLab/pg-erd-cloud#853: 같은 EditTableModal 삭제 동작에 ARIA 라벨을 추가합니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목은 테이블 삭제 시 확인 다이얼로그를 추가한 주요 변경 사항을 명확하고 간결하게 설명합니다.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch palette-table-delete-confirm-17501118382729998255

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

Please perform a fresh independent review of unchanged exact head 726748dcd93519a9780c43b5a68fdf594734e447. All current CI/security workflows are green and no unresolved inline thread is recorded; merge remains deferred until exact-head review evidence is available.

[coderabbitai]

@seonghobae I will perform a fresh independent review of PR #848 at exact head 726748dcd93519a9780c43b5a68fdf594734e447. I will assess the complete change set independently of the current CI status.

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 48 minutes.

[seonghobae]

Exact-current-head independent review request for b824309107c510252e40c86bf5bf45c4fce0969a. CI 31474147985, Security Scan 31474148004, and SAST Semgrep 31474148010 are terminal-success on this SHA, and there are zero unresolved review threads. Review only the table-deletion confirmation, canonical documentation, and removal of the accidental alternate lockfile on this exact head; no predecessor, queued, rate-limited, or status-only evidence transfers.

@coderabbitai review
@opencode-agent review
@cwl-noema-review review

Do not modify the branch, bypass protection, merge, tag, release, or publish.

[coderabbitai]

@seonghobae I will review PR #848 at exact head b824309107c510252e40c86bf5bf45c4fce0969a.

I will limit the review to the table-deletion confirmation, canonical documentation, and removal of the accidental alternate lockfile. I will not modify the branch or perform merge, release, tag, publish, or protection-bypass actions.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[seonghobae]

Owned coverage is now exact on current head d629264ff22222698bb0dbc0250d7474dd2a53df, without production-code expansion. Test-only cases cover the inherited Prisma download, modal cancel/validation, malformed relation-handle, and singular back-relation paths. Local published-tree evidence: 4 focused files / 39 tests passed; full suite 27 files / 200 tests passed; statements 1502/1502, branches 1137/1137, functions 323/323, lines 1357/1357; typecheck, production build, and git diff --check passed. All checks and independent review must be evaluated again on this successor SHA; prior green runs and the review triggered for b824309... are stale.

[seonghobae]

@coderabbitai review

Please perform a fresh independent review and formal verdict for exact current head d629264ff22222698bb0dbc0250d7474dd2a53df. CI 31477644432, Security Scan 31477644544, and SAST Semgrep 31477644502 are terminal-success on this SHA; the frontend suite is 200/200 with exact 100% statement, branch, function, and line coverage; and there are zero unresolved review threads. The previous request and evidence targeted predecessor b824309107c510252e40c86bf5bf45c4fce0969a and must not be treated as current-head evidence.

@opencode-agent @cwl-noema-review Please provide a qualifying independent non-author review for this unchanged exact head. Do not mutate the branch or merge.

[coderabbitai]

@seonghobae I will perform a fresh independent review of PR #848 at exact head d629264ff22222698bb0dbc0250d7474dd2a53df.

I will not use evidence from predecessor b824309107c510252e40c86bf5bf45c4fce0969a. I will not modify the branch or perform merge, tag, release, publish, or protection-bypass actions.

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 49 minutes.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 4: Update the changelog entry’s cancellation clause to state that
cancelling preserves the table, replacing the ambiguous “model” wording while
leaving the rest of the table-deletion confirmation description unchanged.

In `@frontend/src/components/modals/EditTableModal.tsx`:
- Around line 192-195: Remove the duplicate window.confirm from App.tsx’s
onDeleteTable path, while retaining the confirmation in EditTableModal’s onClick
handler that displays editingNode.data.title. Ensure deletion proceeds through
the existing onDeleteTable callback after the modal confirmation without
triggering a second prompt.

In `@frontend/src/erd/__tests__/prisma.test.ts`:
- Line 238: Update the Prisma ERD test around the existing child_parent
assertion to also assert that the children_parents relation generated from the
legacy-id edge is absent from result. Keep the current positive assertion and
add this focused negative assertion so legacy-id edges are explicitly verified
as ignored.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ac559413-b3dd-4a2a-8929-34257c0e18a1

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and d629264.

📒 Files selected for processing (7)

• CHANGELOG.md
• docs/ui-ux/product-spec.md
• frontend/src/App.coverage.test.tsx
• frontend/src/components/modals/EditTableModal.test.tsx
• frontend/src/components/modals/EditTableModal.tsx
• frontend/src/components/modals/ModalCoverage.test.tsx
• frontend/src/erd/__tests__/prisma.test.ts

[seonghobae]

Addressed all three exact-head CodeRabbit findings in d17f5c1a3637cdfb6fb29eaa4024482eb0eb845c:

• removed the redundant App.onDeleteTable confirmation while retaining the named-table confirmation in EditTableModal;
• added an integrated regression proving one canceled attempt plus one confirmed attempt produces exactly two prompts and one deletion (RED before the fix: 3 prompts; GREEN after: 2);
• explicitly asserts the malformed legacy-id Prisma edge does not produce children_parents;
• clarified the changelog cancellation outcome as preserving the table.

Verification: 200/200 frontend tests, exact 100% coverage (1500 statements, 1135 branches, 323 functions, 1356 lines), typecheck, production build, and git diff --check all pass locally. Predecessor workflow results are stale; merge remains deferred pending current-head checks and qualifying independent approval.

[seonghobae]

CI remediation on exact successor 9ab456d71c5ef417b623982a0f1ea0ac94ddc0e4:

• RCA: frontend CI run 31479370980 failed in App.coverage.test.tsx because the empty-search assertion read the DOM immediately after a React search-state update; the same full suite had passed locally, exposing an order/timing-sensitive test boundary rather than a product regression.
• Remedy: await the user-visible empty-search state with Testing Library's async query.
• Focused verification: 1 file, 17 tests passed.
• Full frontend verification: 27 files, 200 tests passed.
• TypeScript typecheck, production build, and git diff --check passed.

Exact-head CI, Security Scan, Semgrep, zero unresolved valid findings, and qualifying independent approval remain mandatory before merge.

[seonghobae]

Exact-current-head independent review request for 9ab456d71c5ef417b623982a0f1ea0ac94ddc0e4.

@opencode-agent @cwl-noema-review Please review this unchanged exact head and provide a qualifying non-author formal verdict. Current-head CI 31480329965, Security Scan 31480329966, and SAST Semgrep 31480329972 are terminal-success; all three prior CodeRabbit findings are addressed and every inline thread is resolved.