Skip to content

🧹 [μ½”λ“œ μƒνƒœ κ°œμ„ ] ConstraintContext dataclass λ„μž… #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 2 commits into from
Closed

🧹 [μ½”λ“œ μƒνƒœ κ°œμ„ ] ConstraintContext dataclass λ„μž… #802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3817cb
🧹 [μ½”λ“œ μƒνƒœ κ°œμ„ ] ConstraintContext dataclass λ„μž…
seonghobae Aug 9, 2026
82ed4b3
🧹 [μ½”λ“œ μƒνƒœ κ°œμ„ ] ConstraintContext dataclass λ„μž…
seonghobae Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 61 additions & 82 deletions backend/app/snowflake_introspect/introspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,19 @@
SUPPORTED_QUERY_PARAMS = {"warehouse", "role", "authenticator"}


@dataclass(frozen=True)
class ConstraintContext:
"""Context holding all the arguments for constraint generation."""

name: str
schema: str
table: str
relation_oid: int
columns: list[str]
constrained_attnums: list[int]
constraint_oid: int


@dataclass(frozen=True)
class SnowflakeDsnConfig:
"""Connection settings parsed from a Snowflake DSN."""
Expand Down Expand Up @@ -281,102 +294,80 @@ def _constraint_def(
return f"FOREIGN KEY ({quoted_cols})"


def _build_primary_key(
name: str,
schema: str,
table: str,
relation_oid: int,
columns: list[str],
constrained_attnums: list[int],
constraint_oid: int,
) -> tuple[dict, list[dict]]:
def _build_primary_key(ctx: ConstraintContext) -> tuple[dict, list[dict]]:
constraint = {
"constraint_oid": constraint_oid,
"constraint_name": name,
"constraint_oid": ctx.constraint_oid,
"constraint_name": ctx.name,
"constraint_type": "p",
"schema_name": schema,
"relation_oid": relation_oid,
"relation_name": table,
"schema_name": ctx.schema,
"relation_oid": ctx.relation_oid,
"relation_name": ctx.table,
"foreign_relation_oid": None,
"foreign_schema_name": None,
"foreign_relation_name": None,
"constrained_attnums": constrained_attnums,
"constrained_attnums": ctx.constrained_attnums,
"referenced_attnums": [],
"constraint_def": _constraint_def("p", columns, None, None, []),
"constraint_def": _constraint_def("p", ctx.columns, None, None, []),
"check_expr": None,
}

pk_columns = []
for ordinal, column in enumerate(columns, start=1):
for ordinal, column in enumerate(ctx.columns, start=1):
pk_columns.append(
{
"constraint_oid": constraint_oid,
"constraint_name": name,
"schema_name": schema,
"relation_oid": relation_oid,
"relation_name": table,
"constraint_oid": ctx.constraint_oid,
"constraint_name": ctx.name,
"schema_name": ctx.schema,
"relation_oid": ctx.relation_oid,
"relation_name": ctx.table,
"column_ordinal": ordinal,
"column_name": column,
}
)
return constraint, pk_columns


def _build_unique_constraint(
name: str,
schema: str,
table: str,
relation_oid: int,
columns: list[str],
constrained_attnums: list[int],
constraint_oid: int,
) -> dict:
def _build_unique_constraint(ctx: ConstraintContext) -> dict:
return {
"constraint_oid": constraint_oid,
"constraint_name": name,
"constraint_oid": ctx.constraint_oid,
"constraint_name": ctx.name,
"constraint_type": "u",
"schema_name": schema,
"relation_oid": relation_oid,
"relation_name": table,
"schema_name": ctx.schema,
"relation_oid": ctx.relation_oid,
"relation_name": ctx.table,
"foreign_relation_oid": None,
"foreign_schema_name": None,
"foreign_relation_name": None,
"constrained_attnums": constrained_attnums,
"constrained_attnums": ctx.constrained_attnums,
"referenced_attnums": [],
"constraint_def": _constraint_def("u", columns, None, None, []),
"constraint_def": _constraint_def("u", ctx.columns, None, None, []),
"check_expr": None,
}


def _build_foreign_key(
name: str,
schema: str,
table: str,
relation_oid: int,
columns: list[str],
constrained_attnums: list[int],
constraint_oid: int,
ctx: ConstraintContext,
referenced_schema: str | None,
referenced_table: str | None,
referenced_columns: list[str],
foreign_relation_oid: int | None,
sorted_rows: list[dict],
) -> tuple[dict, list[dict]]:
constraint = {
"constraint_oid": constraint_oid,
"constraint_name": name,
"constraint_oid": ctx.constraint_oid,
"constraint_name": ctx.name,
"constraint_type": "f",
"schema_name": schema,
"relation_oid": relation_oid,
"relation_name": table,
"schema_name": ctx.schema,
"relation_oid": ctx.relation_oid,
"relation_name": ctx.table,
"foreign_relation_oid": foreign_relation_oid,
"foreign_schema_name": referenced_schema,
"foreign_relation_name": referenced_table,
"constrained_attnums": constrained_attnums,
"constrained_attnums": ctx.constrained_attnums,
"referenced_attnums": [],
"constraint_def": _constraint_def(
"f",
columns,
ctx.columns,
referenced_schema,
referenced_table,
referenced_columns,
Expand All @@ -393,11 +384,11 @@ def _build_foreign_key(
continue
fk_edges.append(
{
"fk_constraint_oid": constraint_oid,
"fk_constraint_name": name,
"child_schema_name": schema,
"child_relation_oid": relation_oid,
"child_relation_name": table,
"fk_constraint_oid": ctx.constraint_oid,
"fk_constraint_name": ctx.name,
"child_schema_name": ctx.schema,
"child_relation_oid": ctx.relation_oid,
"child_relation_name": ctx.table,
"parent_schema_name": referenced_schema,
"parent_relation_oid": foreign_relation_oid,
"parent_relation_name": referenced_table,
Expand Down Expand Up @@ -469,37 +460,25 @@ def _process_constraint_group(
else None
)

ctx = ConstraintContext(
name=name,
schema=schema,
table=table,
relation_oid=relation_oid,
columns=columns,
constrained_attnums=constrained_attnums,
constraint_oid=constraint_oid,
)

if ctype == "p":
constraint, new_pk_columns = _build_primary_key(
name,
schema,
table,
relation_oid,
columns,
constrained_attnums,
constraint_oid,
)
constraint, new_pk_columns = _build_primary_key(ctx)
return constraint, new_pk_columns, []
elif ctype == "u":
constraint = _build_unique_constraint(
name,
schema,
table,
relation_oid,
columns,
constrained_attnums,
constraint_oid,
)
constraint = _build_unique_constraint(ctx)
return constraint, [], []
elif ctype == "f":
constraint, new_fk_edges = _build_foreign_key(
name,
schema,
table,
relation_oid,
columns,
constrained_attnums,
constraint_oid,
ctx,
referenced_schema,
referenced_table,
referenced_columns,
Expand Down
Loading