Skip to content

๐Ÿ›ก๏ธ Sentinel: [MEDIUM] Fix DoS vulnerability in glob pattern parsing - #378

Open
seonghobae wants to merge 2 commits into
masterfrom
fix-dos-pattern-18021474628099128212
Open

๐Ÿ›ก๏ธ Sentinel: [MEDIUM] Fix DoS vulnerability in glob pattern parsing#378
seonghobae wants to merge 2 commits into
masterfrom
fix-dos-pattern-18021474628099128212

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

๐Ÿšจ Severity: MEDIUM
๐Ÿ’ก Vulnerability: .html4ignore ํŒŒ์ผ ๋‚ด์˜ ์ž˜๋ชป๋œ glob ํŒจํ„ด์œผ๋กœ ์ธํ•ด IllegalArgumentException์ด ๋ฐœ์ƒํ•˜์—ฌ ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์ด ์ถฉ๋Œ(DoS)ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Impact: ๊ณต๊ฒฉ์ž๊ฐ€ ํŠน์ˆ˜ํ•˜๊ฒŒ ์กฐ์ž‘๋œ ํŒจํ„ด์„ ์ œ๊ณตํ•˜์—ฌ ์„œ๋น„์Šค ๊ฑฐ๋ถ€(DoS)๋ฅผ ์œ ๋ฐœํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ”ง Fix: getPathMatcher ํ˜ธ์ถœ ์‹œ ํฌ๊ด„์ ์ธ Exception ์ฒ˜๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์ถฉ๋Œ์„ ๋ฐฉ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.
โœ… Verification: ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€ ๋ฐ Gradle ๋นŒ๋“œ ํ…Œ์ŠคํŠธ ํ†ต๊ณผ.


PR created automatically by Jules for task 18021474628099128212 started by @seonghobae

Summary by CodeRabbit

  • ๋ฒ„๊ทธ ์ˆ˜์ •

    • ์ž˜๋ชป๋˜๊ฑฐ๋‚˜ ์†์ƒ๋œ .html4ignore ํŒจํ„ด์œผ๋กœ ์ธํ•ด ์ฒ˜๋ฆฌ ์ค‘ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ•˜๋˜ ๋ฌธ์ œ๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์œ ํšจํ•œ ์ œ์™ธ ํŒจํ„ด์€ ๊ณ„์† ์ ์šฉํ•˜๋ฉด์„œ ๊ธฐ๋ณธ ์ œ์™ธ ๊ทœ์น™๋„ ์ •์ƒ์ ์œผ๋กœ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ

    • NUL ๋ฌธ์ž๊ฐ€ ํฌํ•จ๋œ ์ž˜๋ชป๋œ ํŒจํ„ด์„ ์ฒ˜๋ฆฌํ•˜๋Š” ๊ฒ€์ฆ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64daea8b-163f-496a-a5b5-6a63ffe21e24

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 29e1534 and 3f0bab5.

๐Ÿ“’ Files selected for processing (3)
  • .jules/sentinel.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

๐Ÿ“ Walkthrough

Walkthrough

.html4ignore glob ํŒจํ„ด ์ฒ˜๋ฆฌ์—์„œ ๋ชจ๋“  ๋Ÿฐํƒ€์ž„ ์˜ˆ์™ธ๋ฅผ ๋ฌด์‹œํ•˜๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. ์ž˜๋ชป๋œ NUL ํŒจํ„ด๊ณผ ์œ ํšจํ•œ ๋กœ๊ทธ ํŒจํ„ด, ๊ธฐ๋ณธ index.html ์ œ์™ธ ๋™์ž‘์„ ํ…Œ์ŠคํŠธ๋กœ ๊ฒ€์ฆํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

.html4ignore ํŒจํ„ด ์•ˆ์ „์„ฑ

Layer / File(s) Summary
glob ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ฐ ๊ฒ€์ฆ
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt, .jules/sentinel.md
process_ignore_file์ด PatternSyntaxException ์™ธ์˜ ์˜ˆ์™ธ๋„ ์ฒ˜๋ฆฌํ•ฉ๋‹ˆ๋‹ค. NUL ๋ฌธ์ž๊ฐ€ ํฌํ•จ๋œ ํŒจํ„ด์„ ๋ฌด์‹œํ•˜๊ณ  ์œ ํšจํ•œ *.log ํŒจํ„ด๊ณผ ๊ธฐ๋ณธ index.html ์ œ์™ธ๋ฅผ ์œ ์ง€ํ•˜๋Š”์ง€ ๊ฒ€์ฆํ•ฉ๋‹ˆ๋‹ค. ๋ณด์•ˆ ํ•™์Šต ํ•ญ๋ชฉ์— ๊ด€๋ จ ์˜ˆ๋ฐฉ์ฑ…์„ ๊ธฐ๋กํ•ฉ๋‹ˆ๋‹ค.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • ContextualWisdomLab/html4tree#388: .html4ignore glob ํŒจํ„ด ์˜ˆ์™ธ ์ฒ˜๋ฆฌ๋ฅผ PatternSyntaxException์—์„œ ๋ชจ๋“  Exception ์œ ํ˜•์œผ๋กœ ํ™•์žฅํ•œ ๋ณ€๊ฒฝ๊ณผ ์ง์ ‘ ๊ด€๋ จ๋ฉ๋‹ˆ๋‹ค.

Suggested reviewers: copilot

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ ์ž˜๋ชป๋œ glob ํŒจํ„ด์œผ๋กœ ์ธํ•œ DoS ์ทจ์•ฝ์  ์ˆ˜์ •์ด๋ผ๋Š” ๋ณ€๊ฒฝ์˜ ์ฃผ์š” ๋ชฉ์ ์„ ๋ช…ํ™•ํ•˜๊ณ  ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-dos-pattern-18021474628099128212

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant