fix(desktop): remove synthetic browser analysis success - #827
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production gap
apps/desktop/src/lib/job_runner.tstreated every non-Tauri browser runtime as a complete mock analysis engine: it created an in-memory workspace, queued fake jobs, advanced them with timers, and populated a demo rehearsal song while reportingsucceeded. That success-shaped fallback could make a buyer-visible browser surface look like real analysis.Test-first repair
261253d5910f87992dd48e7741550531e8dc9f92requires enqueue/retry/cancel to fail closed outside Tauri and prohibits synthetic workspace updates/state.bddd8410108d80c81c043a8a1deb911f7e2815d1removes the mock workspace, fake jobs, timers, demo-song construction, and browser mutation path.e5e1b7b2046de5e9b55d2c44140589c3c9cdb9d1records the contract in CHANGELOG.Resulting boundary
nullrather than fabricated state;Keep Draft until the exact current head passes desktop unit/coverage/lint/typecheck/build, security gates, current review, and repository policy.