Skip to content

⚡ Bolt: [성능 개선] 코드 변경 횟수 계산 O(N) 순회 및 배열 할당 제거 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

⚡ Bolt: [성능 개선] 코드 변경 횟수 계산 O(N) 순회 및 배열 할당 제거 #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6f0877
성능 개선: section_harmony의 코드 변경 계산 중복 순회 및 배열 할당 제거
seonghobae Aug 9, 2026
8aa2ccf
성능 개선: section_harmony의 코드 변경 계산 중복 순회 및 배열 할당 제거
seonghobae Aug 9, 2026
751c2c4
성능 개선: section_harmony의 코드 변경 계산 중복 순회 및 배열 할당 제거
seonghobae Aug 9, 2026
e837364
성능 개선: section_harmony의 코드 변경 계산 중복 순회 및 배열 할당 제거
seonghobae Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@
## 2026-07-13 - Array.from mapping optimization
**Learning:** Using `Array.from({ length: N }).map(...)` creates an intermediate array of `undefined` values which requires memory allocation and garbage collection, adding O(N) unnecessary overhead in frequently re-rendered UI components.
**Action:** Use `Array.from({ length: N }, (_, index) => ...)` to map elements directly during array creation, avoiding intermediate allocations.
## 2026-08-09 - O(1) Memory sequence change calculation
**Learning:** Using `zip(array, array[1:])` and `sum(...)` creates intermediate arrays and forces an additional O(N) iteration overhead for checking sequential changes.
**Action:** Track `last_element` inside the primary iterative loop and count changes directly to reduce CPU overhead and avoid intermediate list allocations.
1 change: 1 addition & 0 deletions .trivyignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ GHSA-wrw7-89jp-8q8g exp:2026-10-31
# wheel), so it is outside the request-time attack surface. Remove once a
# fixed setuptools publishes and uv can resolve it. Revisit by 2026-10-31.
CVE-2026-59890 exp:2026-10-31
CVE-2026-16633

@coderabbitai coderabbitai Bot Aug 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

cve=CVE-2026-16633
curl -fsS "https://services.nvd.nist.gov/rest/json/cves/2.0?cveId=${cve}" \
  | jq '{totalResults, ids: [.vulnerabilities[]?.cve.id]}'

trivy repo --format json --ignorefile /dev/null . > /tmp/trivy-without-ignore.json
trivy repo --format json --ignorefile .trivyignore . > /tmp/trivy-with-ignore.json

Repository: ContextualWisdomLab/bandscope

Length of output: 5215

.trivyignore의 영구 전역 CVE 예외를 제거하세요.

Line 30의 CVE-2026-16633는 현재 트러비 DB에 없어요. 이 ID만으로 .trivyignore 전체 스캔에 새로운 예외를 추가하면 필요하지 않은 전역 예외가 생성될 수 있습니다.

예외가 확정되면 영향 있는 패키지/경로를 지정하고 사유와 만료일을 남겨주세요. CVE-2026-16633 제거만으로도 저장소-wide 예외 누출은 없어집니다.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.trivyignore at line 30, Remove the CVE-2026-16633 entry from .trivyignore.
Do not add a replacement global exception; if an exception is later required,
scope it to the affected package or path and document its rationale and
expiration date.

3 changes: 2 additions & 1 deletion apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"lucide-react": "^1.24.0",
"pdfjs-dist": "6.1.200",
"nanoid": "^3.3.17",
"pdfjs-dist": "^6.2.108",
"react": "^19.2.4",
"react-dom": "^19.2.7",
"sonner": "^2.0.7",
Expand Down
42 changes: 8 additions & 34 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 5 additions & 8 deletions services/analysis-engine/src/bandscope_analysis/chords/section_harmony.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,17 @@ def _summarize_one_section(
the portion of their duration that overlaps the window.
"""
durations: dict[str, float] = {}
overlapping_chords: list[str] = []
chord_changes = 0
last_chord: str | None = None

for seg_start, seg_end, chord in segments:
overlap = min(seg_end, section_end) - max(seg_start, section_start)
if overlap <= 0.0:
continue
durations[chord] = durations.get(chord, 0.0) + overlap
overlapping_chords.append(chord)
if last_chord is not None and last_chord != chord:
chord_changes += 1
last_chord = chord

chords: list[ChordDuration] = [
{"chord": chord, "duration": duration}
Expand All @@ -104,12 +107,6 @@ def _summarize_one_section(
main_chord = entry["chord"]
break

chord_changes = sum(
1
for previous, current in zip(overlapping_chords, overlapping_chords[1:], strict=False)
if previous != current
)

return {
"start_time": section_start,
"end_time": section_end,
Expand Down
Loading