Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix CSV Injection (Spreadsheet Macro Injection) Vulnerability - #411

Open
seonghobae wants to merge 2 commits into
developmentalfrom
fix/csv-injection-17764085892087090554
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix CSV Injection (Spreadsheet Macro Injection) Vulnerability#411
seonghobae wants to merge 2 commits into
developmentalfrom
fix/csv-injection-17764085892087090554

Conversation

@seonghobae

Copy link
Copy Markdown

🚨 Severity: HIGH
πŸ’‘ Vulnerability: μ‚¬μš©μžκ°€ μž…λ ₯ν•œ 데이터(μ„Έμ…˜ 이름 λ“±)κ°€ CSV 내보내기 κΈ°λŠ₯μ—μ„œ 특수 문자(예: =)둜 μ‹œμž‘λ  경우, ν•΄λ‹Ή CSVλ₯Ό Excel λ“±μ˜ μŠ€ν”„λ ˆλ“œμ‹œνŠΈ μ•±μ—μ„œ μ—΄μ—ˆμ„ λ•Œ μˆ˜μ‹ λ˜λŠ” 맀크둜둜 싀행될 수 μžˆλŠ” CSV μΈμ μ…˜(Spreadsheet Macro Injection) 취약점이 λ°œκ²¬λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: μ•…μ˜μ μΈ μ‚¬μš©μžκ°€ 특수 문자둜 μ‹œμž‘ν•˜λŠ” ν”„λ‘œμ νŠΈλ‚˜ 제λͺ©μ„ μž‘μ„±ν•  경우, 이 데이터λ₯Ό CSV둜 내보내 μ—΄μ–΄λ³΄λŠ” κ΄€λ¦¬μžλ‚˜ λ‹€λ₯Έ μ‚¬μš©μžμ˜ μ‹œμŠ€ν…œμ—μ„œ μž„μ˜ μ½”λ“œκ°€ 싀행될 μœ„ν—˜μ΄ μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: CSV의 ν•„λ“œλ₯Ό 생성할 λ•Œ, = + - @ \t \r 둜 μ‹œμž‘ν•˜λŠ” 경우 κ°’μ˜ 맨 μ•žμ— 단일 μΈμš©λΆ€ν˜Έ(')λ₯Ό μ‚½μž…ν•˜μ—¬ μŠ€ν”„λ ˆλ“œμ‹œνŠΈκ°€ 이λ₯Ό μˆ˜μ‹μ΄ μ•„λ‹Œ ν…μŠ€νŠΈλ‘œ μΈμ‹ν•˜κ²Œ λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€. λ‘œμ§μ€ lib/server/csv.ts둜 λΆ„λ¦¬ν•˜μ˜€κ³  ν…ŒμŠ€νŠΈλ₯Ό ν¬ν•¨μ‹œμΌ°μŠ΅λ‹ˆλ‹€.
βœ… Verification: pnpm --filter @argos/web run test src/lib/server/csv.test.ts --coverageλ₯Ό 톡해 100% μ½”λ“œ 컀버리지가 λ‹¬μ„±λ˜μ—ˆμŒμ„ ν™•μΈν•˜μ˜€μœΌλ©°, pnpm test 및 pnpm lintλ₯Ό 톡해 λ‹€λ₯Έ κΈ°λŠ₯이 정상 λ™μž‘ν•¨μ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 17764085892087090554 started by @seonghobae

- `packages/web/src/lib/server/csv.ts`λ₯Ό μƒμ„±ν•˜μ—¬ CSV κ΄€λ ¨ μœ ν‹Έλ¦¬ν‹° 뢄리
- `csvField` ν•¨μˆ˜μ— `=` `+` `-` `@` `\t` `\r`둜 μ‹œμž‘ν•˜λŠ” 값에 단일 μΈμš©λΆ€ν˜Έ(`'`)λ₯Ό μΆ”κ°€ν•˜μ—¬ Excel λ“±μ—μ„œ λ°œμƒν•  수 μžˆλŠ” 맀크둜 μ‹€ν–‰(CSV Injection)을 λ°©μ§€
- Dashboard μ„Έμ…˜ 내보내기(`packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts`) 둜직 μ—…λ°μ΄νŠΈ
- λΆ„λ¦¬λœ CSV λ‘œμ§μ— λŒ€ν•΄ 100% ν…ŒμŠ€νŠΈ 컀버리지 μž‘μ„± μ™„λ£Œ (`csv.test.ts`)
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ea1d4a9-9f98-4e8b-ae36-2aa83502a31d

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 4f8796e and 233aebb.

β›” Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
πŸ“’ Files selected for processing (4)
  • .jules/sentinel.md
  • packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts
  • packages/web/src/lib/server/csv.test.ts
  • packages/web/src/lib/server/csv.ts

Comment @coderabbitai help to get the list of available commands.

- OSV-Scanner 및 Trivy-FS CI μŠ€μΊ”μ—μ„œ 발견된 취약점(CVE) ν•΄κ²°
- λͺ¨λ“  μ›Œν¬μŠ€νŽ˜μ΄μŠ€μ— λŒ€ν•΄ `pnpm up -r js-yaml nanoid` μ‹€ν–‰ν•˜μ—¬ νŒ¨ν‚€μ§€ 버전을 각각 4.3.1, 3.3.17 μ΄μƒμœΌλ‘œ μŠΉκΈ‰
- `pnpm audit`으둜 취약점 μ—†μŒ μž¬ν™•μΈ
- λͺ¨λ“  λ‹¨μœ„ ν…ŒμŠ€νŠΈ(`pnpm test`) 및 린트 검사 톡과 확인
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant