CXH-2351: complete the Databricks docs and config cleanup dropped when PR #55 closed - #58
CXH-2351: complete the Databricks docs and config cleanup dropped when PR #55 closed#58al-conductorone wants to merge 2 commits into
Conversation
…d-group ref; fix readme typo
| | Groups | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | | ||
| | Roles | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | | ||
| | Service principals | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | | ||
| | Users | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | |
There was a problem hiding this comment.
🟡 Suggestion: The capabilities table marks Groups as provisionable unconditionally, but README.md and the new docs/docs-info.md both state that account-group provisioning only works with the OAuth (client-id/secret) flow — a workspace token cannot provision groups. Since this PR is the docs cleanup pass, consider adding that caveat here so connector.mdx matches the other two docs.
Connector PR Review: CXH-2351: complete the Databricks docs and config cleanup dropped when PR #55 closedBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review SummaryThe new commit is docs-only: it adds an OAuth-only caveat for group provisioning to Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
…DME/docs-info Add OAuth-only caveat for group provisioning and correct the workspace-token option to reflect that one or more tokens may be supplied, paired positionally with deployment names.
| The Databricks connector supports [automatic account provisioning and deprovisioning](/product/admin/account-provisioning). | ||
|
|
||
| <Note> | ||
| Group provisioning requires OAuth authentication. It is not available when authenticating with a workspace token, because the Databricks API does not allow provisioning groups from a workspace token. |
There was a problem hiding this comment.
🟡 Suggestion: This drops the "account" qualifier that README.md and docs/docs-info.md both use, so it reads broader than the actual limitation. groupBuilder.Grant/Revoke (pkg/connector/groups.go:275, :414) route through the workspace plane when workspaceId != "", which a workspace token can reach — it's account-level groups that are unreachable, since prepareClientAuth only gets workspace-scoped auth for that method (pkg/connector/connector.go:215). Consider scoping the note to account groups.
| Group provisioning requires OAuth authentication. It is not available when authenticating with a workspace token, because the Databricks API does not allow provisioning groups from a workspace token. | |
| Provisioning **account groups** requires OAuth authentication. It is not available when authenticating with a workspace token, because the Databricks API does not allow provisioning account groups from a workspace token. |
Adds the missing Users row to the capabilities list, adds the docs-team input form, removes a stale config field reference that pointed at nothing, and fixes a heading typo. Note: the closed PR's plan to strip out personal-access-token setup was intentionally not revived, since that authentication method is now supported.