add additional flags to place 'count' and 'problem count' ~ 'failed' perfdata metrics to the front of metrics array.#385
Open
inqrphl wants to merge 2 commits into
Conversation
…perfdata metrics to the front of metrics array. this flag is for CheckData struct prepending is slower than appending if its a long list, so its a flag. behavior is opt-in and not default. toggle this flag for check_service, this was the intended target for this. when each service has its own perfdata metric, the count would be appended to the end and generally truncated in previews.
Contributor
|
If we want to check the The Expected Output: |
…ly in perfdata as metric if count is not used, it adds all serices individually
Contributor
Author
|
New behavior: If "count" is used in the thresholds, stop adding each service as perfdata individually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this flag is for CheckData struct, so it can be used alongside any other check that utilizes addCountMetrics.
existing: addCountMetrics
added: addCountMetricsToFront
existing: addProblemCountMetrics
added: addProblemCountMetricsToFront
prepending is slower than appending if its a long list, so its a flag. behavior is opt-in and not default.
toggle this flag for check_service, this was the intended target for this. when each service has its own perfdata metric, which could be above 100 metrics total, the count would be appended to the end and truncated in previews.