Add Auto Announcement Pings for events - #113
Conversation
pikachu0542
left a comment
There was a problem hiding this comment.
Just something to consider, sometimes people like to customize their announcements for something based on the event, whether to be silly, or to mention what will be happening at that meeting, which imo is a good thing.
I like the idea of this, but im not sure how I feel about everything always having an automated ping. It might be worth seeing if you can allow eboard members/ad hoc directors can set whether they want their meetings/events to have automated pings or not.
Pings on events are decided in the event description. You can either put "meeting" "technical" or "seminar" and it will do the appropriate ping. They are not forced my default |
|
Oh, that makes sense. I did notice those keywords being defined but it was unclear to me what the purpose was. In that case, this seems good |
|
Webmasters dont seem to have write access, you are gonna need an RTP |
What
what the PR changes
Adds Automatic pings in announcements for upcoming meetings and seminars
Why
why these changes were made
That way pings for events do get missed, and everything can be standardized
Test Plan
how did you verify these changes did what you expected
Tested running in a private Slack channel (jumpstart to the 5th)
Env Vars
did you add, remove, or rename any environment variables
SLACK_ALLOW_ANNOUNCEMENTS - Whether or not this pod is capable of sending announcements
SLACK_ANNOUNCEMENT_CHANNEL - The slack channel to send announcements to
SLACK_ACTIVE_GROUP_ID - The ID for the active group for pings
SLACK_MEETINGS_GROUP_ID - The ID for the meetings group for pings
SLACK_FROSH_GROUP_ID - The ID for the frosh group for pings
SLACK_TEST_GROUP_ID - The ID to ping nilbert
Documentation
did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.
Documentation was added in code, the zensical documentation still needs to be updated
Checklist