Skip to content

Add Auto Announcement Pings for events - #113

Merged
aln730 merged 3 commits into
mainfrom
auto-announcments
Sep 2, 2026
Merged

Add Auto Announcement Pings for events#113
aln730 merged 3 commits into
mainfrom
auto-announcments

Conversation

@WeatherGod3218

Copy link
Copy Markdown
Collaborator

What

what the PR changes
Adds Automatic pings in announcements for upcoming meetings and seminars

Why

why these changes were made

That way pings for events do get missed, and everything can be standardized

Test Plan

how did you verify these changes did what you expected

Tested running in a private Slack channel (jumpstart to the 5th)

Env Vars

did you add, remove, or rename any environment variables

SLACK_ALLOW_ANNOUNCEMENTS - Whether or not this pod is capable of sending announcements
SLACK_ANNOUNCEMENT_CHANNEL - The slack channel to send announcements to
SLACK_ACTIVE_GROUP_ID - The ID for the active group for pings
SLACK_MEETINGS_GROUP_ID - The ID for the meetings group for pings
SLACK_FROSH_GROUP_ID - The ID for the frosh group for pings
SLACK_TEST_GROUP_ID - The ID to ping nilbert

Documentation

did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.

Documentation was added in code, the zensical documentation still needs to be updated

Checklist

  • Tested all changes locally

@pikachu0542 pikachu0542 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just something to consider, sometimes people like to customize their announcements for something based on the event, whether to be silly, or to mention what will be happening at that meeting, which imo is a good thing.

I like the idea of this, but im not sure how I feel about everything always having an automated ping. It might be worth seeing if you can allow eboard members/ad hoc directors can set whether they want their meetings/events to have automated pings or not.

@WeatherGod3218

WeatherGod3218 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Just something to consider, sometimes people like to customize their announcements for something based on the event, whether to be silly, or to mention what will be happening at that meeting, which imo is a good thing.

I like the idea of this, but im not sure how I feel about everything always having an automated ping. It might be worth seeing if you can allow eboard members/ad hoc directors can set whether they want their meetings/events to have automated pings or not.

Pings on events are decided in the event description. You can either put "meeting" "technical" or "seminar" and it will do the appropriate ping.

They are not forced my default

@pikachu0542

Copy link
Copy Markdown
Member

Oh, that makes sense. I did notice those keywords being defined but it was unclear to me what the purpose was. In that case, this seems good

@pikachu0542 pikachu0542 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pikachu0542

Copy link
Copy Markdown
Member

Webmasters dont seem to have write access, you are gonna need an RTP

@aln730
aln730 merged commit 1d10a59 into main Sep 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants