Conversation
nstepien
commented
Sep 14, 2026
| renderCell(props) { | ||
| return currencyFormatter.format(props.row.budget); | ||
| } | ||
| <li> |
Collaborator
Author
There was a problem hiding this comment.
| return currencyFormatter.format(props.row.budget); | ||
| } | ||
| <li> | ||
| <button type="button" command="close" commandfor={dialogId}> |
Collaborator
Author
There was a problem hiding this comment.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4183 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 45 45
Lines 1943 1947 +4
Branches 732 733 +1
=======================================
+ Hits 1910 1914 +4
Misses 33 33
🚀 New features to boost your workflow:
|
nstepien
commented
Sep 14, 2026
| onChange={(e) => p.onRowChange({ ...p.row, country: e.target.value }, true)} | ||
| onFocus={(event) => { | ||
| try { | ||
| event.target.showPicker(); |
Collaborator
Author
There was a problem hiding this comment.
Somehow it's not opening automatically anymore, had to add this.
I tried calling showPicker() in the ref prop, but that throws an error as it requires an user action.
| > | ||
| <dialog open> | ||
| <input | ||
| autoFocus |
Collaborator
Author
There was a problem hiding this comment.
The dialog automatically focuses the first focusable element
nstepien
marked this pull request as ready for review
September 14, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.