fix(gateway): map /api/notifications to the notification controller path - #92
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/notificationsreturned 404 through the gateway: the route strips its own prefix, butNotificationControlleris[Route("api/[controller]")]— singular — so the forwarded path (/) matched nothing. Re-prefixing after the strip makes the fifth service reachable like the other four."Match": { "Path": "/api/notifications/{**catch-all}" }, -"Transforms": [{ "PathRemovePrefix": "/api/notifications" }] +"Transforms": [ + { "PathRemovePrefix": "/api/notifications" }, + { "PathPrefix": "/api/notification" } +]Pre-existing bug, unrelated to the four extraction PRs; kept in its own PR because
src/ApiGateway/**is off-limits to those branches.Verified on a local integration branch (main + #88 + #89 + #90 + #91) with the full compose stack up:
curl :5000/api/notifications→ 200 with the persisted notification rows, and the other four routes unaffected.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/25839f55096f4d6187d729c0a19f29f9
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/25839f55096f4d6187d729c0a19f29f9?variant=devin
Requested by: @DhrovS