Overhaul localization with external INI language files - #377
Open
MinDeaDBlood wants to merge 86 commits into
Open
Overhaul localization with external INI language files#377MinDeaDBlood wants to merge 86 commits into
MinDeaDBlood wants to merge 86 commits into
Conversation
* [Installer] Update assets * [PE Helper/PXE Helpers/WDSHC] Fix dup. driver inst Essential drivers would be readded by WDSHC. Not anymore * [PE Helper] Tweak build tag * [PE Helper/PXE Helpers/WDSHC] Handle answer file conflicts * [Fix] Fixed phantom item appearing in the CLB Replacing it with a listview seems to fix the issue * [Unattended answer file/DTSS] New WPBT starter script * [Unattended answer file/SSE] INFINITY MK2 improvements - Experimental LIBRARY upload - Bulk conversion - Script security inspection for library upload * [DynaLog] Update init * [Unattended answer file/SSE] Library uploads less experimental * [Unattended answer file] Integrate Starter Script Library * [PE Helper/DT PE ES] Fixed missing param * [Fix] Prevent task failures on rooted sources Like capturing an image, enabling features, adding capabilities and repairing the component store will fail if the source is rooted and contains quotes. This fixes it. * [Fix] Prevent saving online/offline inst information with images selected in mimgmgr * [REL] Update What's New section
* Update assembly information * [Enhance] Improvements to SAM Helper - Improvements for domain accounts - Skip machine.pckgdep and other pckgdeps that don't begin with S-1-5 * [Enhance] Filter appx on 5 criteria * [Fix] Fixed NRE Fixes CodingWonders#372 * [Enhance] Add filter assistant for AppX info dialog * [Enhance] Update startup banner for 4th anniversary * [Unattended answer file/SSE] Allow Automated Inspection training * [PE Helper/PXE Helpers/WDSHC] Show conflict screen more neatly * [Library] Update Markdig to 1.3.2 * [Fix] Reference proper library paths * [Fix] Fixed command issue on rooted path * [BDELIB] Integrate with BitLocker encrypted volumes * [PE Helper] Concurrent ISO creation Concurrent PE Helper = More ISOs at once = Less time spent! * [PE Helper] Fix up path for exported drivers * [Enhance] Allow switching between offline installations from File menu * [Installer] Remove entry to unused item * [PE Helper] Update backgrounds * [PE Helper] Separate progress bars * [PE Helper] Begin bundling BDE-GUI * [DynaLog] Update init * [PE Helper] Pass all arguments to BDEMGR * [REL] Update What's New section
CodingWonders
requested changes
Jul 26, 2026
CodingWonders
left a comment
CodingWonders
left a comment
Owner
There was a problem hiding this comment.
Do not touch the designer code. To switch languages, stick with programmatically handling the translations.
- The designer may fail to render the form, or
- Stuff may be messed up in the designer
- Driver and package info dialogs now support multiple file selection in file pickers - General fixes
CodingWonders
changed the base branch from
dt_prerel_2682
to
dt_prerel_2683_relcndid
August 18, 2026 14:02
Sneaky folders
CodingWonders
changed the base branch from
dt_prerel_2683_relcndid
to
dt_prerel_2691
August 30, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have rebuilt and adapted this localization work on top of your latest
dt_prerel_2681commits.What changed
languagedirectory, including files added after DISMTools has been installed.Designer safety
Following your review, all generated
Designer.vband.resxfiles now match the current base branch exactly. They keep their normal English design-time text. Translations are applied programmatically duringOnLoadfrom ordinary VB source files, using the same external INI files. No localization code runs from the generated designer files.Validation and error handling
The localization system includes strict validation and clear diagnostics. Before a language is applied, DISMTools checks the INI file for missing required keys, invalid numbered placeholders, and syntax errors. An invalid language file is not applied, and the previous language remains active.
If code requests a missing key at runtime, a dedicated localization exception identifies the language file, section, key, full key, and source location. It also explains which entry needs to be added. A detailed validation report is saved under
logs\localization. The program does not silently fall back to another translation.Scope
Apart from the compilation correction described below, all changes in this PR belong to the localization overhaul. Other user-reported fixes discovered during testing have been intentionally excluded. Those can be submitted later as focused commits or separate PRs if you want them.
Compilation correction
There is one small unrelated correction in
ProgressPanel.vb. AnEnd Selectstatement had been appended to the DISM command line, which produced invalid VB code and prevented the project from compiling in our build. I separated it onto its own line in commit3af9310.This correction is isolated in its own commit. If you prefer to keep the original code, let me know and I will remove that single commit from the PR without affecting the localization changes.
Checks
dt_prerel_2681commit available when this update was prepared.Designer.vband.resxfiles have no differences from the current base branch.git diff --checkreports no errors.