Skip to content

refactor: remove dead _prepend_row code in CSV conversion path #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Coding-Dev-Tools merged 1 commit into from
May 18, 2026
Merged

refactor: remove dead _prepend_row code in CSV conversion path #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/datamorph/converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,13 +438,11 @@ def convert(
field_names = [s["name"] for s in schema]
writer.set_field_order(field_names)
elif output_format == "csv":
# Get field order from first few rows for CSV header
# Get field order from first row for CSV header
sample = reader.read_stream(input_path)
try:
first_row = next(sample)
writer.set_field_order(list(first_row.keys()))
# We consumed the first row, so we need to chain it back
sample = _prepend_row(sample, first_row)
except StopIteration:
pass

Expand Down Expand Up @@ -494,12 +492,6 @@ def convert_batch(
return results


def _prepend_row(stream: RowStream, row: Row) -> RowStream:
"""Prepend a row to a stream (for re-inserting a consumed first row)."""
yield row
yield from stream


def _format_to_extension(fmt: str) -> str:
ext_map = {
"csv": ".csv",
Expand Down