Skip to content

[Hermes] Harden CI security, add dependabot, add .gitattributes#16

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
hermes/api-contract-guardian/harden-ci-security-add-dependabot
May 20, 2026
Merged

[Hermes] Harden CI security, add dependabot, add .gitattributes#16
Coding-Dev-Tools merged 1 commit into
mainfrom
hermes/api-contract-guardian/harden-ci-security-add-dependabot

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Summary

Security hardening and repo infrastructure for api-contract-guardian.

Why this change

  • pages.yml checkout was the only workflow missing , leaving the GitHub token in where any later step could exfiltrate it. All other workflows (ci.yml, publish.yml) already had this hardening.
  • dependabot.yml was missing — no automated dependency update tracking for pip or GitHub Actions. Weekly PRs keep deps fresh without manual effort.
  • .gitattributes was missing — no line-ending enforcement, risking CRLF/LF corruption on cross-platform edits (Windows developers committing CRLF, CI seeing diffs).

What changed

  • : Added to checkout step
  • : New — weekly pip + GitHub Actions updates (limit 5 open PRs each)
  • : New — enforce with CRLF exceptions for Windows shell scripts

Validation

  • 139/139 tests pass
  • ruff check: All checks passed
  • YAML files validated with PyYAML
  • Branch pushed successfully

Risks/rollback

  • Very low risk — persist-credentials change is read-only, pages deployment doesn't need git push
  • dependabot.yml only creates PRs, doesn't auto-merge
  • .gitattributes change only affects new commits; existing files unaffected until re-normalized

Follow-ups

  • Monitor first dependabot PRs next Monday
  • Consider adding .editorconfig for multi-language consistency

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

Sentinel review - REQUEST CHANGES: This PR has merge conflicts (dirty state). Please rebase onto current main and resolve conflicts. The changes themselves look good (checkout token hardening + dependabot + .gitattributes) but need a clean branch before merge.

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

🛡️ Sentinel Review: Good changes (CI hardening + dependabot + .gitattributes) but this PR has merge conflicts (mergeable_state: dirty). Please rebase onto main and resolve conflicts before this can be merged.

- Add persist-credentials: false to pages.yml checkout step
  (security: prevents token exfiltration in read-only workflow)
- Add dependabot.yml for weekly pip + GitHub Actions updates
- Add .gitattributes to enforce LF line endings across platforms
@Coding-Dev-Tools Coding-Dev-Tools force-pushed the hermes/api-contract-guardian/harden-ci-security-add-dependabot branch from 7e2baca to 3580818 Compare May 19, 2026 19:49
@Coding-Dev-Tools Coding-Dev-Tools merged commit 8673a20 into main May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant