fix(gate): correct max_breaking/max_dangerous threshold semantics#15
Merged
Coding-Dev-Tools merged 1 commit intoMay 19, 2026
Conversation
The default max_breaking=0 previously meant 'zero allowed' but was ignored when fail_on_breaking=False due to a conditional that skipped max_breaking=0 in favor of the flag. This caused breaking changes to silently pass CI gates when --allow-breaking was set. Change both max_breaking and max_dangerous defaults to -1 (defer to flag). Now: - -1 = use fail_on_breaking/fail_on_dangerous flag (default) - 0 = explicit ceiling: allow zero of that severity - >0 = explicit ceiling: allow N of that severity This makes --max-breaking=0 work correctly with --allow-breaking, preventing silent CI gate bypasses. Adds two regression tests for the previously-broken edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default max_breaking=0 previously meant 'zero allowed' but was
ignored when fail_on_breaking=False due to a conditional that skipped
max_breaking=0 in favor of the flag. This caused breaking changes to
silently pass CI gates when --allow-breaking was set.
Change both max_breaking and max_dangerous defaults to -1 (defer to
flag). Now:
This makes --max-breaking=0 work correctly with --allow-breaking,
preventing silent CI gate bypasses.
Adds two regression tests for the previously-broken edge cases.