fix: rotate terminal PTY session when shell exits to avoid reconnect loop - #26
Merged
Merged
Conversation
…loop The terminal was pinned to a single hardcoded 'default' PTY session. When the backing shell exited (e.g. Ctrl-D at the prompt), that session died and the auto-reconnect looped forever re-attaching to it. The client now sends a sessionId and rotates to a fresh one on shell exit, spawning a new shell. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
coderscreen-api | 2795ab7 | Jul 13 2026, 03:08 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
coderscreen-web | 2795ab7 | Jul 13 2026, 03:09 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room terminal was pinned to a single hardcoded
defaultPTY session, so when the backing shell exited (e.g. Ctrl-D at the prompt) that session died and the client's auto-reconnect looped forever re-attaching to the dead session. The/terminalroute now accepts a client-suppliedsessionId, andTerminal.tsxrotates to a fresh session id when the addon reports the shell exited, remounting the effect and spawning a new shell. Normal network blips still resume the same shell since the session id is stable within a mount.🤖 Generated with Claude Code