fix: use the translated permalink for WPML multilingual shares#1083
Open
vytisbulkevicius wants to merge 1 commit into
Open
fix: use the translated permalink for WPML multilingual shares#1083vytisbulkevicius wants to merge 1 commit into
vytisbulkevicius wants to merge 1 commit into
Conversation
For WPML, each translation is a separate post with its own slug. build_url()
already translated the post id to the account's language, but then also ran the
URL through the wpml_permalink filter, which only rewrites the language
directory and not the slug, producing links like /fr/{wrong-language-slug}.
Build the link from the translated post id and only keep the URL rewrite for
TranslatePress (which uses a single post id per language).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pirate-bot
added
the
pr-checklist-incomplete
Contributor
Soare-Robert-Daniel
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With WPML, Revive Social shared posts with the correct language directory but the wrong slug — the one from the first-added language (e.g.
/fr/{hindi-slug}) — so visitors landed on the wrong page.build_url()already translates the post id to the account's language (so titles were correct), but it then also ran the URL through thewpml_permalinkfilter, which only rewrites the language directory and not the slug. Since WPML stores each translation as its own post, the translated id's permalink is already correct, so the extra rewrite was redundant and corrupted the slug. The URL rewrite is now kept only for TranslatePress, which uses a single post id per language.Will affect the visual aspect of the product
NO
Test instructions
/fr/{french-slug}, not/fr/{hindi-slug}).Check before Pull Request is ready:
Closes https://github.com/Codeinwp/tweet-old-post-pro/issues/556