fix: translation label issues found via make-pot audit#2910
Merged
Conversation
…attribute name label - Move translators comments inside sprintf() calls so terser keeps them next to the __() call in production bundles, making wp i18n make-pot pick them up (%1$s + %2$d more, Image %d alt text). - Fix hover box-shadow Spread control showing raw attribute name hoverBoxShadowSpread as its label and syncing the wrong attribute. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 5f0bf05 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":249.3,"q50":254.3,"q75":271.1,"cnt":10}, firstPaint: {"q25":876.5,"q50":935.5,"q75":1070.3,"cnt":10}, domContentLoaded: {"q25":2290.2,"q50":2314.85,"q75":2366.7,"cnt":10}, loaded: {"q25":2292,"q50":2316.7,"q75":2368.5,"cnt":10}, firstContentfulPaint: {"q25":2595.1,"q50":2625,"q75":2684.6,"cnt":10}, firstBlock: {"q25":9116.9,"q50":9235.85,"q75":9253.2,"cnt":10}, type: {"q25":18.48,"q50":19.17,"q75":20.19,"cnt":10}, typeWithoutInspector: {"q25":17.33,"q50":18.55,"q75":19.19,"cnt":10}, typeWithTopToolbar: {"q25":22.48,"q50":25.38,"q75":27.01,"cnt":10}, typeContainer: {"q25":11.21,"q50":12.55,"q75":13.42,"cnt":10}, focus: {"q25":81.44,"q50":87.18,"q75":93.22,"cnt":10}, inserterOpen: {"q25":27.81,"q50":29.35,"q75":30.64,"cnt":10}, inserterSearch: {"q25":11.24,"q50":12.29,"q75":13.24,"cnt":10}, inserterHover: {"q25":4.39,"q50":4.83,"q75":5.18,"cnt":20}, loadPatterns: {"q25":1112.09,"q50":1128.94,"q75":1167.27,"cnt":10}, listViewOpen: {"q25":141.8,"q50":143.41,"q75":155.55,"cnt":10} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited the generated
.potfiles (wp i18n make-pot) for bothotter-blocksandotter-prodomains and fixed the issues found:translators:comments for%1$s + %2$d more(visibility conditions) andImage %d alt text (alternative text)(slider) existed in source but terser dropped them when merging the surrounding statements into ternary chains, somake-potwarned about placeholder strings with no comment. Moving the comments inside thesprintf()call, directly above the__()argument, makes them survive into the production bundle.hoverBoxShadowSpreadas its label (and sent it to translators). It also wrapped the control inAutoDisableSyncAttrwith the wrong attribute (boxShadowVertical). Both now match the non-hover section.Verification
wp i18n make-potfor both domains: zero warnings, both strings now carry their#. translators:comment in the pot,hoverBoxShadowSpreadno longer appears as a msgid.msgfmt --checkpasses on both generated pots.🤖 Generated with Claude Code