Repository navigation
docs: Migrate Icons, Illustrations, and Patterns into gamut Storybook - #36
Merged
Merged
Conversation
Co-locate the catalog stories within gamut-icons, gamut-illustrations, and gamut-patterns under Media & Assets, scanning those package src dirs from the Storybook config. Exclude stories from each package build and resolve ImageGallery via the ~storybook/blocks path. Remove the old styleguide stories, docs, and the now-unused icon category constants. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LinKCoding
approved these changes
Oct 21, 2026
LinKCoding
left a comment
Contributor
There was a problem hiding this comment.
Looking good to me!
I don't remember if there was a ticket to fix the playground links, but it's in the back of my mind
aresnik11
added this pull request to stack #48
October 23, 2026 19:39
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ajr-migrate-atoms #36 +/- ##
=====================================================
- Coverage 88.96% 88.71% -0.26%
=====================================================
Files 277 355 +78
Lines 5947 6149 +202
Branches 2011 1987 -24
=====================================================
+ Hits 5291 5455 +164
- Misses 646 684 +38
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Co-locates the Icons, Illustrations, and Patterns catalog stories into their own packages (
gamut-icons,gamut-illustrations,gamut-patterns) as stories-as-tests, regrouped under a Media & Assets sidebar section, and removes the old styleguide versions. This matches how the component stories already migrated intogamut/srcrender and run under addon-vitest.What changed
Media & Assets:gamut-patterns/src/Patterns.stories.tsx→Media & Assets/Patternsgamut-illustrations/src/Illustrations.stories.tsx→Media & Assets/Illustrationsgamut-icons/src/Mini.stories.tsx→Media & Assets/Icons/Minigamut-icons/src/Regular.stories.tsx→Media & Assets/Icons/RegularDefaultstory (tested + a11y) plus the visual catalog galleries tagged!testso addon-vitest skips them while they still render in Storybook.constants.tsx.packages/.storybook/main.ts) now scansgamut-icons/src,gamut-illustrations/src, andgamut-patterns/src.tsconfig.jsonexcludes**/*.stories.tsxfrom the build (sotsc --emitDeclarationOnlyignores them) and adds the~storybook/blockspath soImageGalleryresolves.Atoms/{Patterns,Illustrations,Icons}stories, their wrapper.mdxdocs, the IconsAbout.mdxdev guide, and the now-unusedconstants.tsx.Testing
yarn test:stories Patterns Illustrations Mini Regular— all fourDefaultstories pass (incl. a11y).yarn storybookand confirm Media & Assets shows Patterns, Illustrations, and Icons/Mini + Icons/Regular, each with a workingDefaultcontrols panel (icon/pattern/illustration select) and the full visual catalog galleries.Atoms/Patterns,Atoms/Illustrations, andAtoms/Iconsentries are gone.yarn nx build gamut-icons && yarn nx build gamut-illustrations && yarn nx build gamut-patterns— builds succeed anddistcontains no story files.PR Checklist