Repository navigation
feat: zIndex Scale - #11
Open
LinKCoding wants to merge 48 commits into
Open
LinKCoding wants to merge 48 commits into
LinKCoding wants to merge 48 commits into
Conversation
@skillsoft/eslint-plugin-gamut
@skillsoft/gamut
@skillsoft/gamut-agent-tools
@skillsoft/gamut-icons
@skillsoft/gamut-illustrations
@skillsoft/gamut-patterns
@skillsoft/gamut-styles
@skillsoft/gamut-tests
@skillsoft/variance
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage ? 91.35%
=======================================
Files ? 396
Lines ? 6642
Branches ? 2187
=======================================
Hits ? 6068
Misses ? 565
Partials ? 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LinKCoding
marked this pull request as ready for review
October 20, 2026 18:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduces a shared z-index scale so stacking order across Gamut components is consistent, with an ESLint rule and docs to keep raw z-index values out of new code.
zIndexesinpackages/gamut-styles/src/variables/zIndexes.ts(exported fromvariables/index.ts) and wires it into the core theme (themes/core.ts) andvariables/elements.ts. Theme snapshots are updated.gamut-styles/src/variance/config.ts,variance/src/types/config.ts) sozIndexaccepts theme scale keys and raw values.isolation: isolatein places where stacking contexts needed containing.menuPortalstyles, and the z-index type for SelectDropdown.no-raw-z-indexrule toeslint-plugin-gamut(with tests), and enables it inrecommended.ts.BodyPortaland the SelectDropdownmenuPortal.gamut-docs), plus updates to the design tokens, ESLint rules, system props, and foundations index pages.Positioning.stories.tsx, and updates the SelectDropdown and InfoTip stories and the DataList/DataTable docs.gamut-z-indexagent skill and updates related skills (gamut-modal,gamut-select-dropdown,gamut-review,gamut-datalist,gamut-datatable,gamut-component-first,gamut-menu,gamut-system-props,gamut-writing).PR Checklist
Testing Instructions
Don't make me tap the sign.
SelectDropdownstory/docs page, open the dropdown and confirm the menu renders above surrounding content (not clipped by anyoverflow: hiddenancestor) and closes/selects correctly.Foundations/ZIndexstyleguide page and confirm the token table renders and matcheszIndexes.ts(underlaythroughtopmost).eslint-plugin-gamuttest suite (no-raw-z-index.test.ts) and confirm a rawzIndex={2}in a sample component is flagged, andzIndexes.foregroundis not. (npx nx test eslint-plugin-gamut)Popover/Modal/Dialogstory and confirm they still open, close, and stack correctly relative to page content after the ref fixes.PR Links and Envs