London | 26-SDC-July | AYK | Sprint 5 | Prep Exercises CYF-1155 - #643
Open
sarawone wants to merge 9 commits into
Open
London | 26-SDC-July | AYK | Sprint 5 | Prep Exercises CYF-1155#643sarawone wants to merge 9 commits into
sarawone wants to merge 9 commits into
Conversation
sarawone
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work, I have some comments. I think there is one more task, about inheritance. Have you done that one?
| print(imran.dob) | ||
| print(imran.get_age()) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
As part of task 4, can you Explain advantages / disadvantages between class methods vs free functions
|
|
||
| def get_age(self) -> int : | ||
| today = dt.date.today() | ||
| return today.year - self.dob.year |
Contributor
There was a problem hiding this comment.
Is the year the only part you need to consider for this to work?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Hi, there.
Please kindly check and provide feedback on my PR.
Thanks and Regards,
AYK