Glasgow | 26-SDC-July | Mansoor Munawar| Sprint 3 | Implement shell tools - #630
Open
MansoorM11 wants to merge 1 commit into
Open
Glasgow | 26-SDC-July | Mansoor Munawar| Sprint 3 | Implement shell tools#630MansoorM11 wants to merge 1 commit into
MansoorM11 wants to merge 1 commit into
Conversation
…ty txt file to check my output for wc.mjs
This comment has been minimized.
This comment has been minimized.
MansoorM11
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
MansoorM11
added
the
Needs Review
MansoorM11
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start but there is quite a bit of work still to do.
You've built your own argument handling system. Is your way of handling options/arguments always going to be the best? Is there a better way of doing this?
| } | ||
|
|
||
| if (flags.includes("-1")) { | ||
| for (const file of files) { |
Contributor
There was a problem hiding this comment.
is there a more advanced javascript way of printing each item in an array, so you don't have to write a full for loop?
| } else if (flag === "-c") { | ||
| console.log(getByteCount(content), filePaths); | ||
| } else { | ||
| console.log( |
Contributor
There was a problem hiding this comment.
When I tested, i got output that looks very different to the original wc app. Can you find a way to make it look more similar?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented shell tools such as cat, ls and grep.
Task ID: CYF-1150