Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Shell Pipelines#411
Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Shell Pipelines#411M-Abdoon wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
M-Abdoon
added
the
Needs Review
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
- Could you add trailing new lines please to all the scripts?
- You accidentally committed "implement-shell-tools" as well, remove them please
| # The input for this script is the events.txt file. | ||
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| sort events.txt | uniq -c No newline at end of file |
There was a problem hiding this comment.
This groups by the full line (person + event type), producing 2 Entry German, 1 Entry Mariana, etc. - a reader has to sum the numbers to find the totals. The task requires the output to clearly show 5 Entry and 4 Exit. You need to count by event type only
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| # The word "Event" should not appear in your script's output. | ||
| cut -d' ' -f2 events-with-timestamps.txt | sort | uniq -c No newline at end of file |
There was a problem hiding this comment.
events-with-timestamps.txt is tab-delimited, not space-delimited, thus it affects the work of this script
|
|
||
| # TODO: Write a command to output the names of the files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters. | ||
| # Your output should contain 7 files. | ||
| ls sample-files | grep '^[A-Z][a-z]*$' |
There was a problem hiding this comment.
Does it pass something like File1.txt?
|
|
||
| # TODO: Write a command to count the number of files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters. | ||
| # Your output should be the number 7. | ||
| ls sample-files | grep '^[A-Z][a-z]*$' | wc -l No newline at end of file |
There was a problem hiding this comment.
Does it pass something like File2.txt?
|
Could you check my notes please? |
SlideGauge
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Changelist
exercises solved.