London| 2026-MAR-SDC | Imran Mohamed | Sprint 2 | Shell pipelines#384
London| 2026-MAR-SDC | Imran Mohamed | Sprint 2 | Shell pipelines#384i786m wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
i786m
added
the
Needs Review
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Could you check trailing new line presence in the files? Some files does not have it, github highlights it with
| # The input for this script is the events.txt file. | ||
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| sort events.txt | uniq -c No newline at end of file |
There was a problem hiding this comment.
This command groups by the full line, so the output is per-person counts: 2 Entry German, 1 Entry Mariana, 2 Entry Sally, etc. The task says "it should be clear from your script's output that there have been 5 Entry events and 4 Exit events" - a reader has to sum the numbers mentally to get there. You need to count by event type only.
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| # The word "Event" should not appear in your script's output. | ||
| sort events-with-timestamps.txt | uniq -c | grep -v "Event" |
There was a problem hiding this comment.
Because every timestamp+person combination in events-with-timestamps.txt is unique, sort | uniq -c just outputs every line with a count of 1 - it doesn't aggregate Entry vs Exit.
SlideGauge
added
Reviewed
|
Could you address my comments please? |
2 participants
Self checklist
Changelist
Added commands for shell pipelines exercises