Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls - #1518
Open
RaeesStevens wants to merge 19 commits into
Open
RaeesStevens wants to merge 19 commits into
RaeesStevens wants to merge 19 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
|
Thank you for your submission. The following are a quick summary of the fixes needed before this PR can be merged. In Form-Controls/index.html, please remove the extra "X" option from the size dropdown so it matches the required 6 options, and add a pattern attribute (pattern=".[^\s].[^\s].*") to the name input to enforce at least two non-space characters. Additionally, improve the form's semantics and accessibility by moving the size dropdown and submit button outside of the color , and update the size label to use for="size". Finally, please fix the typo in Form-Controls/README.md on line 43 ("JavaScrip" -> "JavaScript"). Once these four items are updated, this will be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls
Self checklist
Task code
CYF-1004
Changelist
Created a form
Added inputs and labels for customer name and email, t-shirt colours and sizes.
Basic form styling using CSS.