Skip to content

Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls - #1518

Open
RaeesStevens wants to merge 19 commits into
CodeYourFuture:mainfrom
RaeesStevens:feature/form-controls
Open

RaeesStevens wants to merge 19 commits into
CodeYourFuture:mainfrom
RaeesStevens:feature/form-controls

Conversation

@RaeesStevens

Copy link
Copy Markdown

Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1004

Changelist

Created a form
Added inputs and labels for customer name and email, t-shirt colours and sizes.
Basic form styling using CSS.

@netlify

netlify Bot commented Sep 13, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 942d555
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aa70f938d4064000833a2f6
😎 Deploy Preview https://deploy-preview-1518--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@RaeesStevens RaeesStevens changed the title Feature/form controls Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls Sep 13, 2026
@RaeesStevens RaeesStevens reopened this Sep 13, 2026
@RaeesStevens RaeesStevens added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 13, 2026
@valentina-starr1

Copy link
Copy Markdown

Thank you for your submission. The following are a quick summary of the fixes needed before this PR can be merged. In Form-Controls/index.html, please remove the extra "X" option from the size dropdown so it matches the required 6 options, and add a pattern attribute (pattern=".[^\s].[^\s].*") to the name input to enforce at least two non-space characters. Additionally, improve the form's semantics and accessibility by moving the size dropdown and submit button outside of the color

, and update the size label to use for="size". Finally, please fix the typo in Form-Controls/README.md on line 43 ("JavaScrip" -> "JavaScript"). Once these four items are updated, this will be good to go.

@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants