Skip to content

North west | 26-ITP-Sept | Brian Yorachi | Sprint 1 | Form controls - #1516

Open
BrianY315 wants to merge 4 commits into
CodeYourFuture:mainfrom
BrianY315:feature/form-controls
Open

BrianY315 wants to merge 4 commits into
CodeYourFuture:mainfrom
BrianY315:feature/form-controls

Conversation

@BrianY315

Copy link
Copy Markdown

Self checklist

  • [X ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [X ] My changes meet the requirements of the task
  • [X ] I have tested my changes
  • [X ] My changes follow the style guide

Needs review

CYF-1004

@netlify

netlify Bot commented Sep 13, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit ccf9091
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aa6d4e6a5e68500083b1233
😎 Deploy Preview https://deploy-preview-1516--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@BrianY315 BrianY315 changed the title Northwest | 26-ITP-Sept | Brian Yorachi | Sprint 1 | Form controls North west | 26-ITP-Sept | Brian Yorachi | Sprint 1 | Form controls Sep 13, 2026
@Liam310 Liam310 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026
@valentina-starr1

Copy link
Copy Markdown

Great work on this,

The form implementation looks solid and addresses all requirements:

Correct input fields and semantic structure (Name, Email, Colour, Size).

Proper regex validation (.\S.\S.*) ensuring at least two non-space characters for the name.

Complete size dropdown list with all 6 required options (XS through XXL).

Strong accessibility setup with linked labels (for) and aria-describedby helper text.

This PR is approved and ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants