Conversation
Enhance median calculation to handle non-array inputs and filter non-numeric values.
Implement describeMedian function to calculate and return the median with error handling.
Add input validation and calculation logic for mean.
mrafeie
changed the title
mrafeie
added
Complete
LonMcGregor
reviewed
Sep 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this PR, most of the tasks look fine, apart from one issue with the initial median task
There was a problem hiding this comment.
Did you run your tests before submitting the PR? I get some errors on the median specifically.
| const median = list.splice(middleIndex, 1)[0]; | ||
| return median; | ||
| } | ||
| const calculateMedian = require("./median.js"); |
| if (numbers.length === 0) { | ||
| return 0; | ||
| } | ||
| return numbers.reduce((total, num) => total + num, 0); |
There was a problem hiding this comment.
Good use of the reduce function here
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1071
Changelist
Sprint1 exercises
Questions