Add restore flow for archived checks - #498
Merged
prestoncabe merged 5 commits intoSep 8, 2026
Merged
prestoncabe merged 5 commits into
prestoncabe merged 5 commits into
Conversation
The Restore button sat outside a confirmation modal, so it stayed live for the whole request. A double click sent two restore calls; the second found the check already active, returned 400, and surfaced "Could not restore check" for a restore that had in fact succeeded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013kjK519eM76gGhLAB8dyZa
Reading a failed Solid resource rethrows, so a failed fetch threw out of createEffect. The home screen has no ErrorBoundary, so a failure of the archived list took down a page whose active list had loaded fine. Check .error before touching the accessor, and cover it with a test that fails (exit 1 on unhandled errors) without the guard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013kjK519eM76gGhLAB8dyZa
The home screen fetched active and archived checks separately, but both come from the same Firestore collection filtered on isArchived, so every page load ran the same query twice and deserialized the same documents twice. Replace the archived=true filter with includeArchived=true, which returns all working checks in one response, and split them in the frontend on the isArchived field that the entity already carries. fetchUserDefinedChecks now takes an options object. Its second positional parameter made it unsafe to hand to createResource, which calls fetchers as fetcher(source, info) -- the truthy info object would have landed in the archived slot and silently requested the wrong list. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013kjK519eM76gGhLAB8dyZa
includeArchived was only honored inside the working=true branch. A request for archived checks without it fell through to the published list, which by construction excludes archived checks -- the caller got the opposite of what it asked for, with a 200 and no signal. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013kjK519eM76gGhLAB8dyZa
prestoncabe
force-pushed
the
487-archived-checks-cannot-be-restored-so-their-name-is-permanently-unusable
branch
from
September 8, 2026 15:40
27d608b to
f2ce812
Compare
prestoncabe
deleted the
487-archived-checks-cannot-be-restored-so-their-name-is-permanently-unusable
branch
September 8, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Archived custom checks can now be discovered and restored, so archived names are no longer permanently unusable.
Changes
Validation