refactor: extract veterinarian directory queries for review demo - #5
Open
ivanmilevtues wants to merge 2 commits into
Open
refactor: extract veterinarian directory queries for review demo#5ivanmilevtues wants to merge 2 commits into
ivanmilevtues wants to merge 2 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a08203-82f5-7539-bc7f-7c6512cf51b8 Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_owner["owner"]
n_vet["vet"]
n_system["system"]
n_model["model"]
n_Loose_files_in_org_springframework_samples_petclinic["Loose files in org.springframework.samples.petclinic"]
n_owner -- "calls" --> n_model
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_vet modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Exercise CodeBoarding review after #4 removed the sync workflow and committed baseline. Leave this PR open to inspect the result.
Change
Extract veterinarian queries and pagination into a VetDirectory service. VetController delegates to it; the HTML and JSON responses remain unchanged. MVC tests import the real service and verify first- and second-page repository requests.
Expected dependency change: VetController → VetDirectory → VetRepository.
Validation
git diff --checkpasses. Maven and Gradle CI will validate the Java changes (the editing orb has no JDK). The CodeBoarding run should show whether a missing baseline triggers fresh base analysis; historical artifacts have not been deleted.