feat: review draft pull requests by default - #121
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a081f0-878f-711e-b4ff-07114b8ea68a Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 0 changed components See the full change in CodeBoarding. graph LR
n_GitHub_Action_Automation_Scripts["GitHub Action Automation Scripts"]
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d638b7f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amp-Thread-ID: https://ampcode.com/threads/T-01a081f0-878f-711e-b4ff-07114b8ea68a Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Svilen-Stefanov
left a comment
There was a problem hiding this comment.
LGTM. One thing that I'm not 100% sure about (not really related to the changes) is if we always want to trigger an analysis upon a state change (e.g converted_to_draft), wdyt?
Amp-Thread-ID: https://ampcode.com/threads/T-01a081f0-878f-711e-b4ff-07114b8ea68a Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0a847118a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amp-Thread-ID: https://ampcode.com/threads/T-01a081f0-878f-711e-b4ff-07114b8ea68a Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Summary
There is no new action input or configuration contract. GitHub evaluates the caller workflow's job condition before invoking a composite action, so draft support belongs in the workflow template rather than
action.yml.Trigger behavior
The dogfood workflow additionally retains
closed, which only cancels an in-flight run and does not start analysis.Validation
python -m unittest discover -s tests- 164 passed, 7 skippedgit diff --check origin/main...HEAD- passed