Skip to content

feat: review draft pull requests by default - #121

Merged
ivanmilevtues merged 4 commits into
mainfrom
feat/configurable-draft-pr-reviews
Sep 8, 2026
Merged

feat: review draft pull requests by default#121
ivanmilevtues merged 4 commits into
mainfrom
feat/configurable-draft-pr-reviews

Conversation

@ivanmilevtues

@ivanmilevtues ivanmilevtues commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

  • make the recommended and dogfood review workflows run for both draft and non-draft pull requests
  • run analysis when a pull request opens, reopens, or receives a new commit
  • avoid rerunning analysis when only the draft state changes
  • document the default behavior

There is no new action input or configuration contract. GitHub evaluates the caller workflow's job condition before invoking a composite action, so draft support belongs in the workflow template rather than action.yml.

Trigger behavior

on:
  pull_request:
    types: [opened, reopened, synchronize]

The dogfood workflow additionally retains closed, which only cancels an in-flight run and does not start analysis.

Validation

  • python -m unittest discover -s tests - 164 passed, 7 skipped
  • Bash syntax checks - passed
  • git diff --check origin/main...HEAD - passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T19:25:45.855706Z 15b0e59 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeboarding-review

codeboarding-review Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

CodeBoarding review

Status: 0 changed components

See the full change in CodeBoarding.

graph LR
    n_GitHub_Action_Automation_Scripts["GitHub Action Automation Scripts"]
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
Loading

download artifacts · run 34268525918

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d638b7f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/action/guard.sh Outdated

@Svilen-Stefanov Svilen-Stefanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing that I'm not 100% sure about (not really related to the changes) is if we always want to trigger an analysis upon a state change (e.g converted_to_draft), wdyt?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0a847118a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/action/guard.sh Outdated
@ivanmilevtues ivanmilevtues changed the title feat: configure reviews by pull request state feat: review draft pull requests by default Sep 8, 2026
@ivanmilevtues
ivanmilevtues merged commit d9e9275 into main Sep 8, 2026
4 checks passed
@ivanmilevtues
ivanmilevtues deleted the feat/configurable-draft-pr-reviews branch September 8, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants