-
Notifications
You must be signed in to change notification settings - Fork 2
TEMP: byok+license at HEAD #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d4ae9e9
4c33369
a14cd8d
2bad192
45e5aa8
c39d5b0
f0cc70f
e4c801f
e3f476a
17c0e8c
0b8f29f
c668bf8
107f35b
ee9cb00
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,4 +111,10 @@ jobs: | |
| echo "::warning::CodeBoarding GitHub App token is unavailable; falling back to github-actions[bot]. Check CODEBOARDING_APP_PRIVATE_KEY formatting if app credentials are configured." | ||
| - uses: ./ | ||
| with: | ||
| # Named, not inferred: the action refuses to guess where credentials come | ||
| # from, so every workflow says which of hosted / license / a provider it | ||
| # wants. CodeBoarding's own repositories run on the CodeBoarding plan. | ||
| llm: openrouter | ||
| openrouter_api_key: ${{ secrets.OPENROUTER_API_KEY }} | ||
| license_key: ${{ secrets.CODEBOARDING_LICENSE }} | ||
|
Comment on lines
+117
to
+119
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For every review run in this repository, selecting Useful? React with 👍 / 👎. |
||
| github_token: ${{ steps.codeboarding-app-token-client.outputs.token || steps.codeboarding-app-token-app.outputs.token || github.token }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a pull request is authored by Dependabot, GitHub withholds Actions secrets, while this workflow's same-repository PR condition still schedules the review job.
OPENROUTER_API_KEYtherefore expands to an empty string and the new protected credential contract intentionally fails withmissing_provider_key, so every Dependabot PR loses its architecture review and may be blocked if this job is required. Gate these PRs or select a credential mode that does not depend on a withheld repository secret for that event context.Useful? React with 👍 / 👎.