[SSF-226] Pantry Deleting & Editing Food Requests Frontend#186
[SSF-226] Pantry Deleting & Editing Food Requests Frontend#186jiang-h-y wants to merge 14 commits into
Conversation
dburkhart07
left a comment
There was a problem hiding this comment.
few things, looking beautiful tho!!
|
Currently, trying to delete a food request as an admin/volunteer will return an error. Pretty sure it's because of role gating in the backend, so I didn't try to fix it for ticket separation purposes. But if it's a different issue/if it's better to address it here, I can fix the role gating. |
There was a problem hiding this comment.
some very small changes so i trust to approve. functionality looks great.
regarding the unauthorized access. perhaps if you want to copy the request.controller file from https://github.com/Code-4-Community/ssf/pull/185/changes#diff-b57a26ea6a57a9ef34ba9812231f9f3dabd0397c2c252a1e777b3a0aa367858b this will allow it to keep the intended functionality
also just make sure the alert comment gets addressed, since that pr should be good to merge.
Yurika-Kan
left a comment
There was a problem hiding this comment.
getting a few nest errors preventing the backend from running correctly:
Nest can't resolve dependencies of the OrdersService (OrderRepository, PantryRepository, DonationRepository, FoodRequestRepository, RequestsService, UsersService, FoodManufacturersService, DonationItemsService, AllocationsService, ?, DonationService, DataSource, EmailsService). Please make sure that the argument PantriesService at index [9] is available in the OrdersModule context. - seems to be from ssf-212
great pr! just some logistics & flattening stuff out~
This is fixed on merging main in |
|
Still waiting on the verdict for colors, but I'm currently using button colors from here: And hover colors from here: |
Yurika-Kan
left a comment
There was a problem hiding this comment.
LGTM you are awesome!


ℹ️ Issue
Closes SSF-226
📝 Description
✔️ Verification
Base Request Modal:

Editing View:

Delete Request Modal:

Success Toast Example:

🏕️ (Optional) Future Work / Notes
Uncaught Error: Your focus-trap needs to have at least one focusable element